Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3756931pxj; Tue, 1 Jun 2021 12:23:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBaV7UBRuED/yfXLW8H5lvnVipW1QJNRiwE2nI+s9Rrqb1tr7sl167lQhfOvlgmztKlh+Z X-Received: by 2002:a17:906:39c6:: with SMTP id i6mr31305775eje.334.1622575434482; Tue, 01 Jun 2021 12:23:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622575434; cv=none; d=google.com; s=arc-20160816; b=KtsAQaUqpRRHhvPL96+LVP/d4qEgeSn59H5jmgQnyaVCBOVkWfCISkbx6YVE6VE0Qb M0TKbB4DClOxXFSRkoajeaMlud6Ikqe/8mfqo/aT1K0FhA4/OWBrs014G9NzWLjNAMqe vfl8qyb9BjIg59cb7E5nvRrsPLC4M8xIfTnAwIAt1ipBoffppSsIrm0KSewjbxuVWWLO Un+zyG6T3SWjtLNxm1QPMxS2WGzg/nHylnjLnHcTpX9JsOKvl4gKwqgX732iXfzjqPHj a2jozyZ2ft6pwFvZVWb5P7wRYkeY+/AfuYS6u0rFPDEwK/0PYS5zYepOddkpd6SO4fCq zzaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bFNYi6m++gbCXTaIyGQySmm0f86eYc/Qr6XGD1RfsTo=; b=IXpW1PPIOjp1x71Q8U9q5XOb+kbKcxmX837pRbGM9VSIqdcTiTBVmGbsqiZrDPfbcM l+7qzGzyBPS/bWfcG0QNgNEmkFVXVj5YLeAG5RY1dHMFbWnHu1Bq0fbcmh+KZMHznmrV xPCxo6HiZ5B6lI9liBiGVsvmhjnk9AxnbL0MBenx11dKJ0M6qcPT089IdQKCKP/Arxbl j7mIaQVns8fynNX2sC8DiCkPdpgBlMi6NR/kRQOjA15kViUmmYt++tlGY1XsRbp5PR0E /1cECClOpE+Psmposy0mN8ggGQH0BMiIhEFr91VGIHaqSExkvY+Hec6ZeKIu54l83Wyt Sqow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nEqGKcRi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si16449139ejc.675.2021.06.01.12.23.31; Tue, 01 Jun 2021 12:23:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nEqGKcRi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234768AbhFATWZ (ORCPT + 99 others); Tue, 1 Jun 2021 15:22:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234654AbhFATWX (ORCPT ); Tue, 1 Jun 2021 15:22:23 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A58FEC061756 for ; Tue, 1 Jun 2021 12:20:40 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id x10so6506979plg.3 for ; Tue, 01 Jun 2021 12:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bFNYi6m++gbCXTaIyGQySmm0f86eYc/Qr6XGD1RfsTo=; b=nEqGKcRi6N4t0IegL+8HbfXnUJ+QjBc/I85UjwK8r+2W1OajAAHtMS52fDLvCq5I42 VQf1aq9ltt4QTVpgYd8h00ZVL5ORJBjfBrIgvpKvAODbvgtZqYI0k2qAWnP7QvmYhjzE yzlvivuoc8Ey5s/YsQJXDgWJv/8i7HS9xfmQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bFNYi6m++gbCXTaIyGQySmm0f86eYc/Qr6XGD1RfsTo=; b=mB3oVnNgSiek46Uukce7+uGMWx8yFCyfD9vt905IectYeQMFkFy3rpBHRoqM40ykD1 yXGKbNmBDgqG/eAup6Xrlaj8CI4kql68Lpvvl6ovNYX71RiDNwEiT7oaIndsS5VlZ/Fp jiUZ3bfS6Vh2c9qBsgKihO4ZXsKyxmGdP9Z7zHGWag+QVRhsq/uAl3+GUc34yuEWlPlu YxGRQsnC6Al8Z1FtErAKBh1GDIomPryRzetMEaw210F/yP0Ou12pFiqdnqyxWUFwPSJ7 MBH06EX/RRfh190OGS9M88/Qp0NrGB8HmhVhixpjNdwdfR70nAESBBKtRND1Jico+zNh 5hqg== X-Gm-Message-State: AOAM530yRY7vaJJxynZKGAK3riS9qmBFKZGHKQIsel64wu+uvtBYwVpq a5RefJrdFy6/144EjJ4ho3ffwA== X-Received: by 2002:a17:90a:9f02:: with SMTP id n2mr1451581pjp.190.1622575240135; Tue, 01 Jun 2021 12:20:40 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c134sm13949779pfb.135.2021.06.01.12.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 12:20:39 -0700 (PDT) Date: Tue, 1 Jun 2021 12:20:38 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Larry Finger , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] staging: rtl8188eu: Fix fall-through warnings for Clang Message-ID: <202106011220.C226177E0@keescook> References: <20210528200650.GA39289@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528200650.GA39289@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 03:06:50PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead > of just letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook