Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr
To:     Wei Liu <wei.liu@kernel.org>
Cc:     linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mikelley@microsoft.com,
        viremana@linux.microsoft.com, sunilmut@microsoft.com,
        vkuznets@redhat.com, ligrassi@microsoft.com, kys@microsoft.com
References: <1622241819-21155-1-git-send-email-nunodasneves@linux.microsoft.com>
 <1622241819-21155-13-git-send-email-nunodasneves@linux.microsoft.com>
 <20210529215548.okh67gtegsa4fd7r@liuwe-devbox-debian-v2>
From:   Nuno Das Neves <nunodasneves@linux.microsoft.com>
Message-ID: <35ef9495-df4e-ef3e-e730-c3708bbfe6bd@linux.microsoft.com>
Date:   Tue, 1 Jun 2021 12:49:46 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210529215548.okh67gtegsa4fd7r@liuwe-devbox-debian-v2>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/29/2021 2:55 PM, Wei Liu wrote:
> On Fri, May 28, 2021 at 03:43:32PM -0700, Nuno Das Neves wrote:
> [...]
>>  int mshv_synic_init(unsigned int cpu)
>>  {
>>  	union hv_synic_simp simp;
>> @@ -30,7 +126,7 @@ int mshv_synic_init(unsigned int cpu)
>>  	*msg_page = memremap(simp.base_simp_gpa << HV_HYP_PAGE_SHIFT,
>>  			     HV_HYP_PAGE_SIZE,
>>                               MEMREMAP_WB);
>> -	if (!msg_page) {
>> +	if (!(*msg_page)) {
> 
> This hunk belongs to the previous patch in which you introduced this
> function, not this one.
> 
> Wei.
> 
Hmm I think I messed up a rebase. Thanks for catching it!