Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp60983pxj;
        Tue, 1 Jun 2021 15:10:00 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyhXjHz9AZWmajhFm9b0+/puxDxzIazTSzBB4gVOSdgEcwmV3CozfEGTvi3uiUK9rYxercl
X-Received: by 2002:a92:d589:: with SMTP id a9mr4052947iln.175.1622585400787;
        Tue, 01 Jun 2021 15:10:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1622585400; cv=none;
        d=google.com; s=arc-20160816;
        b=FW0TenNfm9oInd4UqKrjEu93azwf061XKbIemgkMhNyGN1y2xgabKxNGEdHLa7dGSR
         Uwsm14VkOIxfEc1aCNPIpT4vpO/2tH3ux0gC6LxdSIwZYsbZOezZgXpPxJ25oqNea13a
         iPZqhxwgjNCKotincqf+FBPM5R2YjZUhWQCxPnLo8lW+9fqWyjKoqdjiiqh4RWbCEiUN
         oJjjT94onVGaK9Z9qiYWur+BRGPo2hmeK/MFzjErWQZ8mnCj6UxItw5p+TuO6PpK7yXF
         mpALbh9P2hlbuQMFg2cN2YjoEdldg0Ai+F704xZo6SvJ0wm/2pILhAI/TCBUeKjkorID
         VN+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=FtHxG6xUI+ZK/LdOWImVo2KBg5IQssGdB+TkgX8DaAc=;
        b=sEUj2mQ8KSb1l2sHFFxgkx5vin0UFe4S1EByQM2fQm0U22cZ5iUftrI4BxMeN/KVYK
         EK/gwygUN3qNiVBsu5K9D74CU41L+OxepWZbCZ89SZO8mUKndSB3hiS/cShPnZ2iudOY
         XFxjDqJjSauJAQzYwpTsgKp4pRHwIjx2HOa91lnVCH5N4cPi/1Yp8+CADh60PcuK3wNm
         oln4I7O56FvRe7J8zALPFgZmfWwYs8sUkVKWNjwG0zN7K5skuPXWf/yJXyPoW4cx5sSt
         Mv/nh1qMs51L+HqhCrgQc3H/sJd6IbNn/nRLa7Fw3BfheAOnxhQha7heIuzUI98zDgN1
         JaDA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=07F7bXGF;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l12si11833179ils.9.2021.06.01.15.09.47;
        Tue, 01 Jun 2021 15:10:00 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=07F7bXGF;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235016AbhFAWJm (ORCPT <rfc822;lukasz.wituch.linux@gmail.com>
        + 99 others); Tue, 1 Jun 2021 18:09:42 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:39666 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S234897AbhFAWJk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Jun 2021 18:09:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=FtHxG6xUI+ZK/LdOWImVo2KBg5IQssGdB+TkgX8DaAc=; b=07F7bXGF6o2GkIt8YI5oQtaLJl
        GzHjxDA/eXv6w4vO5Gmy2VHFMqWYbq7va2EhmbRi5HG5YZ4p4xRpoOQ4IInl/fuUvlUz24w5NunKH
        SCdVry8Y5mhDETT957/nbzuM1JPVaVNrovPsOE6BqTvVH91gXS/pD/yGFI5ZQD9UEbDM=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1loCYA-007LxQ-F7; Wed, 02 Jun 2021 00:07:50 +0200
Date:   Wed, 2 Jun 2021 00:07:50 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
        hkallweit1@gmail.com, linux@armlinux.org.uk, f.fainelli@gmail.com,
        linux-imx@nxp.com, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: phy: realtek: add dt property to
 disable CLKOUT clock
Message-ID: <YLavtkj5YO4WGlLd@lunn.ch>
References: <20210601090408.22025-1-qiangqing.zhang@nxp.com>
 <20210601090408.22025-3-qiangqing.zhang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210601090408.22025-3-qiangqing.zhang@nxp.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +struct rtl821x_priv {
> +	u32 quirks;

I'm not sure quirks is the correct word here. I would probably use
features, or flags.

	  Andrew