Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp84935pxj; Tue, 1 Jun 2021 15:51:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2vqFtfh527fRB3n4IHCCUrL9pO1QgZ0mbGenzv2BeQPfXst0/X4UU33BjpiTyZbne6dzy X-Received: by 2002:a17:906:b191:: with SMTP id w17mr31545874ejy.200.1622587910108; Tue, 01 Jun 2021 15:51:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622587910; cv=none; d=google.com; s=arc-20160816; b=QJDYczxNjl5/1xt/wM3WdIpGh+BITCTZtv3i5KrQ826AC+Co8WuLqHaitqPcdb8xvr tpBS3BEsmCo06FcKH9DtP38xyhYwPwKrE+oLwA77PUUKgg4wuS0rhThBEY/vzR5sQpDo R2Xp7p+sIcWcvuKtU9vOvxMAWBZE/bsI7KzQhpTwNv4TiF3gisqFuHqxfse+6gpyBmkW A4bM/xX89pkNURWRVMb+5FGelj5YDCIRGUuCzuV9zR2h9LyPMJszhcAUhl3wLss+4s+I +0MI7x1KM8MGUAnW3KPr9KmvcRhxfOvo91xqVO/B07Aw1oOQtlc5Ss96TiPJEjOB70/w 83Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=UgZP50WmeKA4RRpiifyPgMd+0QGruqLCfgf2xRco+1s=; b=TiMymxjFAmd/TI9CgligRebtInH+CdtTgbKhgWU/vGZnAkPyXRPsjJ3RQxmUirY4rh 5WvDPOlGMTM8Fej42oDYjBUvrrtqkgQPog76UgbbEsQEfxjV5OwDYC/XUuEQT47INeoC H0rqpO1Rf++7FTtm24VeqtYsL7xoWvhM/9eSrMF59Vn8REShLGktuqPUsoDms0SFAqeh IcLcwklcGgS7cLajmwkI2PQBcDWvmvxSjAtByaS56iXSdbFagbVd5HUMV/C1AIEp0jTe etCYUUke+Z7N/KivNujXRO4So9cuGuNXxAcWJ4794DfA9sZjswrwODFXuJwXf5xL3pJK 1SsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l20si16888449ejn.131.2021.06.01.15.51.27; Tue, 01 Jun 2021 15:51:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235054AbhFAWvU (ORCPT + 99 others); Tue, 1 Jun 2021 18:51:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:6579 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234766AbhFAWvU (ORCPT ); Tue, 1 Jun 2021 18:51:20 -0400 IronPort-SDR: SLmoiT+tkzCEo3i39l8onyHkyUYsqqzptOmPrpr506z0ZKLLri3FfB7pTNTWrVLSKF+LY2NgDd Q9OIpJdfFiow== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="224938895" X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="224938895" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 15:49:38 -0700 IronPort-SDR: xaKiwBq64AhFAALOwOrE+uVnU8Ol3XG+BDdLfVUdB6LtDUWaiFnwrpK3oiMHwhgb+LH/X+B3xR 9PIM9FMi6ubw== X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="474416967" Received: from cble-mobl.amr.corp.intel.com (HELO [10.209.7.186]) ([10.209.7.186]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 15:49:36 -0700 Subject: Re: [PATCH 4/5] x86/pkeys: replace PKRU modification infrastructure To: Dave Kleikamp , Babu Moger , Dave Hansen , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, luto@kernel.org, shuah@kernel.org, linuxram@us.ibm.com, bauerman@linux.ibm.com, bigeasy@linutronix.de References: <20210527235109.B2A9F45F@viggo.jf.intel.com> <20210527235118.88C9831B@viggo.jf.intel.com> <0f98bc0a-3ee4-3fe9-f7c6-9c2b873bec38@amd.com> <5617bb6d-2202-53f4-8b4d-7b3e72ca0158@oracle.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <519bbb92-8744-9da2-a8c1-c0c64fbd8005@intel.com> Date: Tue, 1 Jun 2021 15:49:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5617bb6d-2202-53f4-8b4d-7b3e72ca0158@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/21 3:43 PM, Dave Kleikamp wrote: > On 6/1/21 4:54 PM, Babu Moger wrote: >> Hi Dave, >> Thanks for the patches and trying to address the issues. >> >> I know these patches are in early stages and there is still a discussion >> on different ways to address these issues. But I wanted to give a try >> anyway. >> >> Tried to boot the system with these patches. But system did not come up >> after this patch(#4). System fails very early in the boot process. So, I >> could'nt collect much logs. It failed both on AMD and Intel machines. >> I will try to collect more logs. >> Thanks >> Babu > > Same here. Hitting this line in arch/x86/include/asm/fpu/xstate.h > >         BUG_ON(!(xstate->header.xcomp_bv & BIT_ULL(xfeature_nr))); > > [    0.384929] kernel BUG at arch/x86/include/asm/fpu/xstate.h:177! Thanks for the report. I am, indeed, reworking this code a bit. I'll pay close attention if this code remains in some form.