Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp88880pxj; Tue, 1 Jun 2021 16:00:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNPC6dKdgG1Cun6SnQNrxrQOOK4VJ2SLsDM0srfscYTvADp2ZRraI8h/Mqzazsg9aHij5y X-Received: by 2002:a17:906:d1d5:: with SMTP id bs21mr9073064ejb.378.1622588406699; Tue, 01 Jun 2021 16:00:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622588406; cv=none; d=google.com; s=arc-20160816; b=KMSS60MekF5Z6zBDR8pt5HhYUyg0ojs9wfAXcFddQUy/vjPIAKRlY7GXG7vNKGfHPB S4cPa8A60WY34dbnikLTZhhQmH6+xq5U8sL86i8eu3nHqvBL/SASLWQbbd3FLW3p7JRX 1QTupe3ms38BPfTVQtz4o8t+9XbCsIWdgfnWvFNRIqcgn9I3vQFL7ZzDPvQp1wlfTziD HF7pgcj+eyVzFwV2QpfYbuDZ5Rd4yHL/Ct6c6ZaWvMuXKVxgzKlPahiddMhgGSPpOez9 wTvAze3m5mDBWXPkrUL2EIp6tyB0pALEwW0qrU5nyJDi3fQnhGCb3qW2j9XgOIUHxtfI ATAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q4W+RK/UiZcP5P0EH3Iqdu3xr4J+8uHojy7d0BiHPOs=; b=YbvThRG2y0AS/Jo4dgkUsYvAQf4UCQURJitun0hS65KcEYg9I9K+ccX3jzTlBbcUfA K2v4Usdg3g1PLsmMfMDiRDnQKAdcH+IqkH+9gej4suKJAZEeuoxAyI5S+0sAkyDLIVsq xZAZiKeEscxonp66przFoU8/cI8MxWmYQJv8IwanvpnBBVMy55eMi+xI8eiHzZdwUiti SgPX0m3yTPESQ3rdr/cb1bwXeNN/JQu/3o/gXkVuXpSjsO+6XSm11UiDPlQede+NgcQq ijdmrcU5d3FSUNgK2+1EyulouEr+A5+W4XEfOW6OTsP6RmR9ZcfC8F1eskEbFSio392u R/9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K4sAZIjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f22si3281960ejb.54.2021.06.01.15.59.41; Tue, 01 Jun 2021 16:00:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K4sAZIjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234908AbhFAW5R (ORCPT + 99 others); Tue, 1 Jun 2021 18:57:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234766AbhFAW5Q (ORCPT ); Tue, 1 Jun 2021 18:57:16 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFBF4C06174A for ; Tue, 1 Jun 2021 15:55:33 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id k15so670498pfp.6 for ; Tue, 01 Jun 2021 15:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q4W+RK/UiZcP5P0EH3Iqdu3xr4J+8uHojy7d0BiHPOs=; b=K4sAZIjojCaVRqT19cKzjJjekM/E2k55Fz+Lx+6O2Gj8Bhhtk4dxz+77Ls/pahp8nc C5FG0KnJGCq/A2tw3323CuxbBIAsfE0CvdIMyUQLWCBovrSpK8DGHD4IEH0ERo6JZnY5 H3EWjFP5YcYR1aicQH6gMgF2spNmUHE+rvSMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q4W+RK/UiZcP5P0EH3Iqdu3xr4J+8uHojy7d0BiHPOs=; b=WFJSBTgVhvvh4ZGy9J5mVFO6qoIEMWB2Nm0Ff1Rh4VPUY++uDwC4CIwWfhrYjuKds/ 2FT9707v29TNDJjo8LLnJrVmYChVXWeRpbr9BOUaAetK8UOWA2rxXfSau3pqKXtxkO3v Uf0eeenlLygU7TliLLW4kE1NimeKkLuYavybM4Fh5sfe6hLjgwCa0dIa/spAtw6vWiNW Kd1wNWYGl0cdjS9aN0KgOxot5hH+hkXr5UKXNy2qbAULlZHDDW/RH16v8nlYUQGhObOx 5bhtM8vKUKwanJjLmAXmlG8/83EhtwqMO+LY+ZLLjJwRzgwXBDegqUIgEq569pskdhhg RnIQ== X-Gm-Message-State: AOAM5311dJWjohM2FKULCVBWzAlzfv+5AVFKh+03uP4Wl2n5FkTGtdNk JH3Moo9VbF09PWZ4LnfJW1xpWA== X-Received: by 2002:a62:5285:0:b029:2e9:e0d5:67dc with SMTP id g127-20020a6252850000b02902e9e0d567dcmr9839597pfb.79.1622588133205; Tue, 01 Jun 2021 15:55:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g11sm2784904pgh.24.2021.06.01.15.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 15:55:32 -0700 (PDT) Date: Tue, 1 Jun 2021 15:55:31 -0700 From: Kees Cook To: jarmo.tiitto@gmail.com Cc: Bill Wendling , LKML , Nathan Chancellor , Jonathan Corbet , Linux Kbuild mailing list , clang-built-linux , Andrew Morton , Nick Desaulniers , Sami Tolvanen Subject: Re: [PATCH] pgo: rename the raw profile file to vmlinux.profraw Message-ID: <202106011555.A7E9BE38@keescook> References: <20210531202044.426578-1-morbo@google.com> <202106011210.B5A8881214@keescook> <5615959.Mqr2uNrfH2@hyperiorarchmachine> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5615959.Mqr2uNrfH2@hyperiorarchmachine> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 02, 2021 at 12:40:25AM +0300, jarmo.tiitto@gmail.com wrote: > Yes, my future intention is that there will be one *.profraw file per module. > And curiously I would also have renamed the current profile data file to > "vmlinux.profraw" to disambiguate it from what part of kernel generated it. > > I already wrote an small fix up that I think should be part of the upstream > code so that profiling the vmlinux works better. > It filters out any module originated content from vmlinux.profraw. > > Above will be probably a good exercise for me. > > Next, my future v2 module profiling machinery > would probably follow on top of your work. Okay, great; thanks for digging into it! :) -- Kees Cook