Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp119795pxj; Tue, 1 Jun 2021 16:53:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy96QmM5b2ur7HuRJZBlKOpo4Jt01O9s6Tu+ylsOeLRGjiPCpP4+CueXOXYS2yULNoQMinx X-Received: by 2002:a02:6d6c:: with SMTP id e44mr27531267jaf.81.1622591626594; Tue, 01 Jun 2021 16:53:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622591626; cv=none; d=google.com; s=arc-20160816; b=sbUbjE+JRvmedgznO2kUKBRd0Np5BMJ93S48P6Mc3glAVRUZFR6+qXhpC2fxMi6fXn 86ecdwljJWTz7d+Z5XdZx4SCFF3HuAjnR2R+Ww73NNBVX57o+E+uNozvwIb3q/1GSmav NNRECErCucEZt9atqR4gL2HgZud2Oni78YFUrUa+Dz9o8njW4VUDA4eopUMkHMKZTlqX 1m1hK0dFYVzOCbm2VtWbXdGkVJdX19qrYohm4DqWcMqUpry83Y3jWXRhiKLPP5o2rJJb a+H1KMl5KUB4Yc7kaaW8wtbhRiIgTLzk4C5HfLzF2oWwy7ux/X1uXXy27N+wDBFmH1sz lmcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=OMSdmvmIsGd57NdGQv9+qet8GH9DbjZj+S3K7d13eK8=; b=sXFPgl2nbfpiGDwf0HXvhM9RUd8ytGfv8Uya/rGVTUUdEmkpeZhgLZel7SHtlKELmt QNqgjOBbohHGKBmCCYC6adHkNCNU9AOCYcQrLZWPYqdfF743GxNXgpWWt2fx/f5MNcDH KsA1UUZ6YQQ0xkW0kwSAs/N9RNMvt71bYTbwWPk8dHcD9ghvxTkHctaI9QGOesZhNGV1 Rga2unHL1RIzCfCQS/SMBVu7mdZuarTLeTrsTVSWSIKDLf+iVdjGMR7sEfqKqn4RwOy8 I/BbWkzkdkHdZ1Pzcg9MpR6naCHAYR8ziyZugWpcXwHbebDEKJh9cxXtjC17rsJ6/Z4f lsYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=HCyhQjon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si11276663jai.106.2021.06.01.16.53.32; Tue, 01 Jun 2021 16:53:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=HCyhQjon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235199AbhFAXya (ORCPT + 99 others); Tue, 1 Jun 2021 19:54:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235137AbhFAXy3 (ORCPT ); Tue, 1 Jun 2021 19:54:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 70F0E613AD; Tue, 1 Jun 2021 23:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1622591567; bh=dxjDIz0r0b7xu1n9w+LYp4IakkKBhTx8Jn5ZMEZwbhI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HCyhQjonnStyx/IAf6j38G5VoiTAkwlYEGBOjWwsTQRs9d74mqf0NIB6G9LdowvNg 06s4vaky2uliZYTTcrBHtdLErU12UipwM8Aqzb7u303acCyzFmTU6JaEsi+VvCVr0d B4feOWRTx/LtL6nVZMHV5JUfKevSWoHIaGwUrPTE= Date: Tue, 1 Jun 2021 16:52:46 -0700 From: Andrew Morton To: David Hildenbrand Cc: Dong Aisheng , Dong Aisheng , linux-mm@kvack.org, open list , Dave Young , Baoquan He , Vivek Goyal , kexec@lists.infradead.org Subject: Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections Message-Id: <20210601165246.99d7374d07661b7e91e49cb6@linux-foundation.org> In-Reply-To: References: <20210531091908.1738465-1-aisheng.dong@nxp.com> <20210531091908.1738465-5-aisheng.dong@nxp.com> <42617372-c846-85fe-4739-abbe55eca8f6@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand wrote: > > Thanks, i explained the reason during my last reply. > > Andrew has already picked this patch to -mm tree. > > Just because it's in Andrews tree doesn't mean it will end up upstream. ;) > > Anyhow, no really strong opinion, it's simply unnecessary code churn > that makes bisecting harder without real value IMHO. I think it's a good change - mem_sections refers to multiple instances of a mem_section. Churn is a pain, but that's the price we pay for more readable code. And for having screwed it up originally ;)