Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp237702pxj; Tue, 1 Jun 2021 20:33:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy456qqyIkQS0QoRIHqVYp/CwtD2GtneXp10AZI1UC052gu2ZpvUgvxPIdhPyPJZAnKgqOv X-Received: by 2002:a05:6638:a48:: with SMTP id 8mr28706766jap.38.1622604802692; Tue, 01 Jun 2021 20:33:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622604802; cv=none; d=google.com; s=arc-20160816; b=agzW3XNdqruE/V3pZeZ9/zct7mu9pXQPgZ1aSAneRRwhE3EIjFzjhc563hanH9TS2g CQ+KBOPtJt2a4vcFtOMc3GETPzfRqTWxmBCdVQFDak92LtH/nMGH1T73T/u/3UdQOUtL qWG8nc4aRvaEFCUrkTPG5q/edJrqg1hqZ/+rHOhYyOzRqGOFraLd/eoFBuIQ6yyU80BO kRCOPP6RK3Zo0XLA9RNrorLEpKDaSknhGoVuLPCOLAZrNeNzouzP9cZ7A3fqchgrbeiG qCw/jnusoM9oVN6BPcdavV50HXTdEOo46EHFWbb3cdLXh12iIEdkSVmeZP1WUoZD7dRc n3Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=aU8YQE+PsE008vh6Ohq/Fid1+7EKuFME5/j3EOjv6ss=; b=BBLjYAda/08C1WCy2+A1uZ6CdU+35wHbV1fE0IP8UK0NSH7eS4MgFGOhzuj1aA3cBp xBQUV6NHBF/uOLhmlsain8gzRW7WApSJE6KmU6fM/4maMa4/GT/T+oBDB70JnHsaizHg DZE3tQ4HC+0xrXS6B6H+eR4E/UJUHtftM4cyuGAzvRsEY3pOoaXtnCFT6VhzO9gcX8li c5ucW07pf0B4uFwtBn0N3jZbYrbA+FKHaDjoklNSeXADdt9I5rhCRFJphILVsUZ0SccQ 8FjsUVOC1TMjCTckw9DbiK9YzviQ/A3OgUgd9XH6ng7DWwB+Qf0PfLVfdqZP/4KqKrFg RuLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si2721601jat.74.2021.06.01.20.33.04; Tue, 01 Jun 2021 20:33:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbhFBBJB (ORCPT + 99 others); Tue, 1 Jun 2021 21:09:01 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:3328 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbhFBBJA (ORCPT ); Tue, 1 Jun 2021 21:09:00 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FvrNV5vjwz1BH2h; Wed, 2 Jun 2021 09:02:34 +0800 (CST) Received: from dggema761-chm.china.huawei.com (10.1.198.203) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 09:07:14 +0800 Received: from [10.174.178.46] (10.174.178.46) by dggema761-chm.china.huawei.com (10.1.198.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 2 Jun 2021 09:07:14 +0800 Subject: Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe() To: Mathieu Poirier CC: , , , , References: <20210601083100.130776-1-chengzhihao1@huawei.com> <20210601152047.GA1759269@xps15> From: Zhihao Cheng Message-ID: <73c51d6a-50e1-a7da-1c6f-66fb397c82ef@huawei.com> Date: Wed, 2 Jun 2021 09:07:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20210601152047.GA1759269@xps15> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggema761-chm.china.huawei.com (10.1.198.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2021/6/1 23:20, Mathieu Poirier ะด??: > On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote: > > @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev) > mem_names[i]); > pru->mem_regions[i].va = devm_ioremap_resource(dev, res); > if (IS_ERR(pru->mem_regions[i].va)) { > - dev_err(dev, "failed to parse and map memory resource %d %s\n", > - i, mem_names[i]); > https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/ Thanks for reminding. Ignore this patch. >> ret = PTR_ERR(pru->mem_regions[i].va); >> return ret; >> } >> -- >> 2.31.1 >> > .