Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] soc: imx: gpc: add check for of_match_device in
 imx_gpc_old_dt_init
To:     Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>
References: <20210601100256.70030-1-tongtiangen@huawei.com>
 <DBBPR04MB7930A304416458880D69E1C7873E9@DBBPR04MB7930.eurprd04.prod.outlook.com>
 <CAOMZO5CKW5n4P9X5tTHGcS-MkN=gmCkyS1+bkwn98kaK2vL3-w@mail.gmail.com>
CC:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From:   tongtiangen <tongtiangen@huawei.com>
Message-ID: <3b50ca69-5482-a6a0-cf29-6898dbd61b26@huawei.com>
Date:   Wed, 2 Jun 2021 10:06:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <CAOMZO5CKW5n4P9X5tTHGcS-MkN=gmCkyS1+bkwn98kaK2vL3-w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/6/1 22:04, Fabio Estevam wrote:
> On Tue, Jun 1, 2021 at 7:11 AM Jacky Bai <ping.bai@nxp.com> wrote:
>
>> I think there is no chance to pass 'invalid of_id' and 'of_id_data' to the probe function.
>> Such check seems not really necessary.
> I agree. The only way this driver can probe is via device tree.
> .
ok,  there is no problem in practical use.   thanks all.
>