Subject: Re: [BUG] 2.6.19-rc3 autofs crash on my IA64 box
From: Ian Kent <raven@themaw.net>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: "bibo,mao" <bibo.mao@intel.com>, David Howells <dhowells@redhat.com>,
       linux-kernel@vger.kernel.org
In-Reply-To: <20061102183020.446D.Y-GOTO@jp.fujitsu.com>
References: <45485478.8060909@intel.com>
	 <20061102183020.446D.Y-GOTO@jp.fujitsu.com>
Content-Type: text/plain
Date: Thu, 02 Nov 2006 18:21:16 +0800
Message-Id: <1162462876.6980.8.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1394
Lines: 43

On Thu, 2006-11-02 at 18:51 +0900, Yasunori Goto wrote:
> Hello.
> 
> > hi,
> >   2.6.19-rc3 kernel crashes on my IA64 box, it seems the problem
> > of autofs fs. I debug this problem, if autofs kernel does not
> > match daemon version, it will call autofs_catatonic_mode.
> > But at that time sbi->pipe is NULL.
> > 
> > void autofs_catatonic_mode(struct autofs_sb_info *sbi)
> > {
> >    .........
> >    fput(sbi->pipe);        /* Close the pipe */
> > 	^^^^^^^^^^^^
> >  	sbi->pipe seems NULL;
> >    autofs_hash_dputall(&sbi->dirhash); /* Remove all dentry pointers */
> > }
> > 
> 
> My box crashed too.
> 
> Following fix does not seem enough.
> http://marc.theaimsgroup.com/?l=linux-kernel&m=116110204104327&w=2

I'm not surprised it addresses a completely different problem.

> If version does not match at autofs_fill_super(), then sbi->pipe
> is not set yet.
> I suppose something like following patch is necessary.

At least but I'll need to check a bit further into this and the autofs4
module should be updated in a similar manner. Even though it will
support the latest requested version it should still handle this error
case.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/