Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Rg24ilX1x/rWh+RQDZytjVh77cLG9fpOymsSi1HxeLc1WOOfQodKQ+aCXgODIvE5PbfCj4GNTp
 QSm4gL0UAFhA==
IronPort-SDR: /jGuQacTW6w0bEroq9Ox6VWPEpRMzvyVO3WFegBnstguy2SurVW0+TuaJu/vKxaFlSmf+lgHBx
 Yt2VarDsO80g==
Message-ID: <ede3060df241fa00e0ea994006af206e8bc8e6ec.camel@intel.com>
Subject: Re: [PATCH] ACPI: tables: fixes the missed acpi_put_table() in
 acpi_init_fpdt()
From:   Zhang Rui <rui.zhang@intel.com>
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>, rjw@rjwysocki.net,
        lenb@kernel.org
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 02 Jun 2021 15:28:02 +0800
In-Reply-To: <20210602011723.23666-1-jingxiangfeng@huawei.com>
References: <20210602011723.23666-1-jingxiangfeng@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi, Xiangfeng,

thanks for the patch.

On Wed, 2021-06-02 at 09:17 +0800, Jing Xiangfeng wrote:
> acpi_init_fpdt() misses to call acpi_put_table() in an error path.
> Add
> the missed function call to fix it.
> 
> Fixes: d1eb86e59be0 ("ACPI: tables: introduce support for FPDT
> table")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Acked-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui
> ---
>  drivers/acpi/acpi_fpdt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
> index a89a806a7a2a..4ee2ad234e3d 100644
> --- a/drivers/acpi/acpi_fpdt.c
> +++ b/drivers/acpi/acpi_fpdt.c
> @@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)
>  		return 0;
>  
>  	fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
> -	if (!fpdt_kobj)
> +	if (!fpdt_kobj) {
> +		acpi_put_table(header);
>  		return -ENOMEM;
> +	}
>  
>  	while (offset < header->length) {
>  		subtable = (void *)header + offset;