Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1619341721-5580-1-git-send-email-jrdr.linux@gmail.com> <24534cc6-e6dc-feda-1e2f-b9b3501845d9@infradead.org>
In-Reply-To: <24534cc6-e6dc-feda-1e2f-b9b3501845d9@infradead.org>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Wed, 2 Jun 2021 13:52:25 +0530
Message-ID: <CAFqt6zbX0bOgqcp_575p4T+qTcycS2AhEmrAkZ7+hXrC-K4QfA@mail.gmail.com>
Subject: Re: [PATCH] mtd: rawnand: marvell: Minor documentation correction
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     miquel.raynal@bootlin.com, Richard Weinberger <richard@nod.at>,
        vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 25, 2021 at 9:52 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 4/25/21 2:08 AM, Souptick Joarder wrote:
> > Kernel test robot throws below warning ->
> > drivers/mtd/nand/raw/marvell_nand.c:454: warning: This comment starts
> > with '/**', but isn't a kernel-doc comment. Refer
> > Documentation/doc-guide/kernel-doc.rst
> >
> > Minor documentation correction.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > ---
> >  drivers/mtd/nand/raw/marvell_nand.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> > index 79da6b0..e7b48d4 100644
> > --- a/drivers/mtd/nand/raw/marvell_nand.c
> > +++ b/drivers/mtd/nand/raw/marvell_nand.c
> > @@ -451,7 +451,7 @@ struct marvell_nfc_timings {
> >  };
> >
> >  /**
> > - * Derives a duration in numbers of clock cycles.
> > + * TO_CYCLES*() - Derives a duration in numbers of clock cycles.
>
> Hi--
>
> Did you test that?  I would be surprised if kernel-doc stays quiet
> with that change.

Sorry, I missed this thread. yes it's wrong.
Reason -> I posted the wrong patch.
I will correct it in v2.

>
> [testing]
>
> Yep, kernel-doc doesn't like to see that '*' there.
> That doesn't work.
>
> >   *
> >   * @ps: Duration in pico-seconds
> >   * @period_ns:  Clock period in nano-seconds
> >
>
>
> --
> ~Randy
>