Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp450015pxj; Wed, 2 Jun 2021 03:18:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSz3bLB0nAV3Lc7glrNSThy56HHo72L4xMmA5RVwbF4EVMmK7V1T23h3YLhAGMnEhjSCwW X-Received: by 2002:a05:6402:254d:: with SMTP id l13mr38370007edb.281.1622629118746; Wed, 02 Jun 2021 03:18:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622629118; cv=none; d=google.com; s=arc-20160816; b=OJQbh55JHLEyRTWriNu/+rje6PQJav8MvKH1c5t0agZPpkgZsB4z2XH4jzF5dOV3M5 xZdwxod5kicALZGyfveLg/VhAVQcg/Jvy6VvNBvygeRh481xJ+bqJLRUeZyyDOLw5iFD GJfnyX88cMgCR4B9dKVoALJPQvmf16pmONepY8MNoLhGCXlyyzKoTis28Kblyh7YM5RT I8t3DxZ/C7LRHUzZwQjBGvI0n7kq9bxDtMaFP1wczSkqGoY39NYSqNeZtfc5aiF7QV5j tZp73K2saZvC3t1uAHWW6BA7OV5gaG8Vfe/PCQ70f6L0EBlKJPAfHjqMMmn3Z1kvYLef 0weg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=AR8jRW6Gpdqlk8p71vtjmRvT6S+tFh5eEziieASAj10=; b=wiHVolwqTG3c5QZzzUv//0Z0/PZJLUgQrMcVUHqi/xTQhTq5c2NzfSzdjZfNlOFqhj YEndt/XwS6bN/Zrc6u0Wht0UD16BkF03MWaifcRsz9zFXvIAqa86Dkdh8f8dSMKX3Xqv ZK/jYAzJZaPiKjAyoeIYTa2s8GghDhJvFU+fMZAql5WbWtWjAIRdFUTnf9n1I6QdjOzS lGsob2P9kz25BqBpd17+EKEOVp0hIa29Zr8rqrM4vcXl94XrHXFQlRVqsV2Lv3mCIfZp wwKvWyTiUYcCRo/Iu9GWAIGqkzbrtrrhpb/cNJyd9GAnd1bDjeZQjaT6WF6KK1P+7IdU J0Qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si10189380eji.332.2021.06.02.03.18.15; Wed, 02 Jun 2021 03:18:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbhFBKJY (ORCPT + 99 others); Wed, 2 Jun 2021 06:09:24 -0400 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:59870 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231621AbhFBKJU (ORCPT ); Wed, 2 Jun 2021 06:09:20 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0Ub2KBTb_1622628451; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Ub2KBTb_1622628451) by smtp.aliyun-inc.com(127.0.0.1); Wed, 02 Jun 2021 18:07:35 +0800 From: Jiapeng Chong To: dave.jiang@intel.com Cc: vkoul@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] dmaengine: idxd: Fix missing error code in idxd_cdev_open() Date: Wed, 2 Jun 2021 18:07:26 +0800 Message-Id: <1622628446-87909-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/dma/idxd/cdev.c:113 idxd_cdev_open() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/dma/idxd/cdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c index 302cba5..d4419bf 100644 --- a/drivers/dma/idxd/cdev.c +++ b/drivers/dma/idxd/cdev.c @@ -110,6 +110,7 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp) pasid = iommu_sva_get_pasid(sva); if (pasid == IOMMU_PASID_INVALID) { iommu_sva_unbind_device(sva); + rc = -EINVAL; goto failed; } -- 1.8.3.1