Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nava kishore Manne <navam@xilinx.com>
To:     Moritz Fischer <mdf@kernel.org>
CC:     "trix@redhat.com" <trix@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, git <git@xilinx.com>
Subject: RE: [PATCH 3/3] fpga: region: Adds runtime PM support
Thread-Topic: [PATCH 3/3] fpga: region: Adds runtime PM support
Thread-Index: AQHXJ6KdTpEiWN/+bESGWLEVPH0Elqqsv+2AgA6mmuCARYO/AA==
Date:   Wed, 2 Jun 2021 10:48:42 +0000
Message-ID: <PH0PR02MB733699A67717E605045728DAC23D9@PH0PR02MB7336.namprd02.prod.outlook.com>
References: <20210402092049.479-1-nava.manne@xilinx.com>
 <20210402092049.479-4-nava.manne@xilinx.com> <YHDHhf1tQo6vI49W@epycbox.lan>
 <MWHPR02MB2623E61ABFBB478E95DC863FC2499@MWHPR02MB2623.namprd02.prod.outlook.com>
In-Reply-To: <MWHPR02MB2623E61ABFBB478E95DC863FC2499@MWHPR02MB2623.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W8tJRvbKQMui90NHMAtFU/+HvWxJuj99L81aRYsHDx159BcIyI7tivnvgKgU?=
 =?us-ascii?Q?jsQ0x7RBTagSLmK3YvX2Pv+opu67xmcUzMxS3DGnkECLBv5sWFXklzxTBJRz?=
 =?us-ascii?Q?34O8jqOF27NVWKn3Pq1znQezqnTBPwiciAmlHCEORFz8QzmulgdaemY1EV4t?=
 =?us-ascii?Q?DhXzBihj31Xc8ROtiRpXzczuoSLO2HFAC5X1fdtXZJ5pdwaJJUvbJQliNB3c?=
 =?us-ascii?Q?3H5OBmN2THXc22YUh9swGUUBFY8zLEeGc+B994gx+m9zCuswHJ1NenVJSwl0?=
 =?us-ascii?Q?L9x0cXX/FyHCChktVQylyzZ7aXCYJa4tm27R17WbEmgbHiLjynwALxMgoun6?=
 =?us-ascii?Q?8GYlj1uyO3zTCaV1dsYv/J/6GzKjLOFSPumZE+EWKp8rpth+0Q3VrofJeox2?=
 =?us-ascii?Q?QVU4Oy2xkklNK6TEeps0f076qMi5dwVBmpsi7m6NQ+NvxqC+4GnW5qbgIDTZ?=
 =?us-ascii?Q?og1mbAwZH4pYSc10qo/DZBwe5Vm/tiFb+HqLS+5BlaGOKq90bgCRrgByi9vR?=
 =?us-ascii?Q?nnYYZ4RQKynIy0wcHDknjDXYlz6bDS0Z+2p+nQ7z67P5Iwm+Up+EC4w5k9JR?=
 =?us-ascii?Q?6rJORpqWzvKxc0lf1hvnRVXtzwlZ0DxsPEiWmGJVcP+89d9mYFLqs7c09GuY?=
 =?us-ascii?Q?sEqvPR2Tq5xhmCfBXGu+MCVu0g22EwPcs0i8BPbXYz8UFtYAz23uqh6s2p3K?=
 =?us-ascii?Q?hhrKaZ0XWuzU3u6R8IZkB28ZAqyZXMfeSekWptwBUEY+gIXswx9oty8EoCdP?=
 =?us-ascii?Q?mY0Cx2ev39SE3w4t6e7fJHsCCerW5+SpIDIcbcdP/Tuf4OD8uRJzA7u4R+/H?=
 =?us-ascii?Q?Rpxfak9hpRcuYLutlhd+fx6xyFE769zebb+Afob1fNDoFarz8KsvTJqhFUwl?=
 =?us-ascii?Q?0dbpu3C9MXBP9heRZBt6m99MjRaaumnOVj3KWYlcvqTLfqqKftNe4JjPlP74?=
 =?us-ascii?Q?WYtYY6JPRTrD4HIrbUg/hn3x3NtGgWX2qLoZR19qd1268lQxZz/dbomhquBG?=
 =?us-ascii?Q?/Ix5+LjCXPjl6MG9M0yFHGoAwNzXrETJrEUlZcN7FrB6j7awc/aeZoVMn2n7?=
 =?us-ascii?Q?Fokhxk36nO5/qOWfIoR24/DtkPGuq1zxyY0PzUQx9lLTB4MoMNbLCJ3bj3Cn?=
 =?us-ascii?Q?dQv7XLm0aDK5WPrc2Y8PCBDGHTKUpwsOlCMJK+XmXPHXGMPYvZoY5QfPVrl/?=
 =?us-ascii?Q?Y+AQHD8/QhZmTge8COELJYI1dkMNILx0QzYrbZyp6IDHMCS3LeDhLcpzOte/?=
 =?us-ascii?Q?tzbnxsbrDQTbswvOXnSV2/JoriUgLpQv3KMx0DqrZCjjC+sahweBxLH7uhTk?=
 =?us-ascii?Q?4FMWxCLpHZny9Lr6fRuLGr+y?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7336.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 018dd33d-1684-4940-f52a-08d925b3fcf7
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2021 10:48:42.1176
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4QuQQVm3WxOdRkDxvdx1ENUFvpzLCDr9bfTbHRHIxVHStJIiTlbVrAHG6n6hhxM+2EkS5Ytr8A/pssO+S/5vMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7239
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ping!

> -----Original Message-----
> From: Nava kishore Manne
> Sent: Monday, April 19, 2021 10:49 AM
> To: Moritz Fischer <mdf@kernel.org>
> Cc: trix@redhat.com; robh+dt@kernel.org; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; git <git@xilinx.com>
> Subject: RE: [PATCH 3/3] fpga: region: Adds runtime PM support
>=20
> Hi Moritz,
>=20
> 	Please find my response inline.
>=20
> > -----Original Message-----
> > From: Moritz Fischer <mdf@kernel.org>
> > Sent: Saturday, April 10, 2021 3:01 AM
> > To: Nava kishore Manne <navam@xilinx.com>
> > Cc: mdf@kernel.org; trix@redhat.com; robh+dt@kernel.org; Michal Simek
> > <michals@xilinx.com>; linux-fpga@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; git <git@xilinx.com>
> > Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support
> >
> > On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote:
> > > Adds support to handle FPGA/PL power domain. With this patch, the PL
> > > power domain will be turned on before loading the bitstream and
> > > turned off while removing/unloading the bitstream using overlays.
> > > This can be achieved by adding the runtime PM support.
> > >
> > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > > ---
> > >  drivers/fpga/of-fpga-region.c | 18 +++++++++++++++++-
> > >  1 file changed, 17 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/fpga/of-fpga-region.c
> > > b/drivers/fpga/of-fpga-region.c index e405309baadc..35fc2f3d4bd8
> > > 100644
> > > --- a/drivers/fpga/of-fpga-region.c
> > > +++ b/drivers/fpga/of-fpga-region.c
> > > @@ -15,6 +15,7 @@
> > >  #include <linux/of_platform.h>
> > >  #include <linux/slab.h>
> > >  #include <linux/spinlock.h>
> > > +#include <linux/pm_runtime.h>
> > >
> > >  static const struct of_device_id fpga_region_of_match[] =3D {
> > >  	{ .compatible =3D "fpga-region", },
> > > @@ -302,6 +303,7 @@ static int
> > > of_fpga_region_notify_pre_apply(struct
> > fpga_region *region,
> > >  	}
> > >
> > >  	region->info =3D info;
> > > +	pm_runtime_get_sync(dev->parent);
> > >  	ret =3D fpga_region_program_fpga(region);
> > >  	if (ret) {
> > >  		/* error; reject overlay */
> > > @@ -324,10 +326,13 @@ static int
> > > of_fpga_region_notify_pre_apply(struct fpga_region *region,  static
> > > void
> > of_fpga_region_notify_post_remove(struct fpga_region *region,
> > >  					      struct of_overlay_notify_data
> > *nd)  {
> > > +	struct device *dev =3D &region->dev;
> > > +
> > >  	fpga_bridges_disable(&region->bridge_list);
> > >  	fpga_bridges_put(&region->bridge_list);
> > >  	fpga_image_info_free(region->info);
> > >  	region->info =3D NULL;
> > > +	pm_runtime_put(dev->parent);
> > >  }
> > >
> > >  /**
> > > @@ -411,9 +416,16 @@ static int of_fpga_region_probe(struct
> > platform_device *pdev)
> > >  		goto eprobe_mgr_put;
> > >  	}
> > >
> > > +	pm_runtime_enable(&pdev->dev);
> > > +	ret =3D pm_runtime_get_sync(&pdev->dev);
> > > +	if (ret < 0)
> > > +		goto err_pm;
> > > +
> > > +	pm_runtime_put(&pdev->dev);
> > > +
> > >  	ret =3D fpga_region_register(region);
> > >  	if (ret)
> > > -		goto eprobe_mgr_put;
> > > +		goto err_pm;
> > >
> > >  	of_platform_populate(np, fpga_region_of_match, NULL, &region-
> > >dev);
> > >  	platform_set_drvdata(pdev, region);  @@ -422,6 +434,9 @@ static
> > >int of_fpga_region_probe(struct  platform_device *pdev)
> > >
> > >  	return 0;
> > >
> > > +err_pm:
> > > +	pm_runtime_put(&pdev->dev);
> > > +	pm_runtime_disable(&pdev->dev);
> > >  eprobe_mgr_put:
> > >  	fpga_mgr_put(mgr);
> > >  	return ret;
> > > @@ -434,6 +449,7 @@ static int of_fpga_region_remove(struct
> > > platform_device *pdev)
> > >
> > >  	fpga_region_unregister(region);
> > >  	fpga_mgr_put(mgr);
> > > +	pm_runtime_disable(region->dev.parent);
> > >
> > >  	return 0;
> > >  }
> > > --
> > > 2.18.0
> > >
> >
> > Does this add a dependency on CONFIG_PM?
> >
> Yes, the newly added functionality has a dependency on CONFIG_PM if it's
> disabled the expected power domain (in our cases it's PL) will not powere=
d
> ON/OFF dynamically at runtime and this is as an expected behavior. Other
> than this it will not impact the any of the driver existing functionality=
.
>=20
> Regards,
> Navakishore.