Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ming Qian <ming.qian@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>
Subject: RE: [EXT] Re: [PATCH 1/5] dt-bindings: media: imx8q: add imx video
 codec bindings
Thread-Topic: [EXT] Re: [PATCH 1/5] dt-bindings: media: imx8q: add imx video
 codec bindings
Thread-Index: AQHXVcfqGsnUGl1w80aC15AYWxJrYKr/KXwAgAE3oCA=
Date:   Wed, 2 Jun 2021 08:09:42 +0000
Message-ID: <AM6PR04MB6341C4C9DAC65CE808BD4511E73D9@AM6PR04MB6341.eurprd04.prod.outlook.com>
References: <cover.1622429025.git.ming.qian@nxp.com>
 <dd2c66ba07a8025da2c377c1b6e46f9d7304c9bc.1622429026.git.ming.qian@nxp.com>
 <1622554330.037290.242362.nullmailer@robh.at.kernel.org>
In-Reply-To: <1622554330.037290.242362.nullmailer@robh.at.kernel.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 21a8c702-6d48-4985-ba9f-08d9259dc6b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2021 08:09:42.2097
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VBRg/iU/13Jg2zRVI/tBYD2weJJXrZArLq1JnHcGdd+sjtfd3Z+XusiP9JhyRPPKZo61H76y2O0VXrMwvvtMiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4613
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Mon, 31 May 2021 10:51:09 +0800, Ming Qian wrote:
> > Add devicetree binding documentation for IMX8Q Video Processing Unit
> > IP
> >
> > Signed-off-by: Ming Qian <ming.qian@nxp.com>
> > Signed-off-by: Shijie Qin <shijie.qin@nxp.com>
> > Signed-off-by: Zhou Peng <eagle.zhou@nxp.com>
> > ---
> >  .../bindings/media/nxp,imx8q-vpu.yaml         | 201
> ++++++++++++++++++
> >  1 file changed, 201 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml
> >
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml:24:9:
> [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml:67:13:
> [warning] wrong indentation: expected 10 but found 12 (indentation)
> ./Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml:94:7:
> [warning] wrong indentation: expected 8 but found 6 (indentation)
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/medi=
a
> /nxp,imx8q-vpu.yaml: properties:mu_m0: Additional properties are not
> allowed ('vpu_core' was unexpected)
>         hint: Keywords must be a subset of known json-schema keywords
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdevice=
tr
> ee.org%2Fmeta-schemas%2Fkeywords.yaml%23&amp;data=3D04%7C01%7Cmin
> g.qian%40nxp.com%7Ce1c1c81d4bf349f4551408d92501bba0%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C637581511648466898%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3Dz5K2eJR%2FKDI7GZbxzI733VSgAI
> R%2FI4sx9Visl21IJe8%3D&amp;reserved=3D0
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/medi=
a
> /nxp,imx8q-vpu.yaml: properties:mu_m0: 'vpu_core' is not one of ['$ref',
> 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'co=
ntains',
> 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum',
> 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minim=
um',
> 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern',
> 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize'=
,
> 'unevaluatedProperties', 'uniqueItems']
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdevice=
tr
> ee.org%2Fmeta-schemas%2Fkeywords.yaml%23&amp;data=3D04%7C01%7Cmin
> g.qian%40nxp.com%7Ce1c1c81d4bf349f4551408d92501bba0%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C637581511648466898%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3Dz5K2eJR%2FKDI7GZbxzI733VSgAI
> R%2FI4sx9Visl21IJe8%3D&amp;reserved=3D0
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/medi=
a
> /nxp,imx8q-vpu.yaml: 'oneOf' conditional failed, one must be fixed:
>         'unevaluatedProperties' is a required property
>         'additionalProperties' is a required property
>         hint: A schema with a "$ref" to another schema either can define =
all
> properties used and use "additionalProperties" or can use
> "unevaluatedProperties"
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdevice=
tr
> ee.org%2Fmeta-schemas%2Fbase.yaml%23&amp;data=3D04%7C01%7Cming.qia
> n%40nxp.com%7Ce1c1c81d4bf349f4551408d92501bba0%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C637581511648466898%7CUnknown%7
> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C1000&amp;sdata=3D5XtViMjNpB5Xk6d82g%2FCb54xz2J2jK
> crmhXa5cusqNA%3D&amp;reserved=3D0
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/medi=
a
> /nxp,imx8q-vpu.yaml: ignoring, error in schema: properties: mu_m0
> warning: no schema found in
> file: ./Documentation/devicetree/bindings/media/nxp,imx8q-vpu.yaml
> Documentation/devicetree/bindings/media/nxp,imx8q-vpu.example.dt.yaml:0:
> 0: /example-0/vpu-bus@2c000000: failed to match any schema with
> compatible: ['nxp,imx8qm-vpu', 'simple-bus']
> Documentation/devicetree/bindings/media/nxp,imx8q-vpu.example.dt.yaml:0:
> 0: /example-0/vpu-bus@2c000000/vpu_decoder@2d080000: failed to match
> any schema with compatible: ['nxp,imx8q-vpu-decoder']
> Documentation/devicetree/bindings/media/nxp,imx8q-vpu.example.dt.yaml:0:
> 0: /example-0/vpu-bus@2c000000/vpu_encoder@2d090000: failed to match
> any schema with compatible: ['nxp,imx8q-vpu-encoder']
> Documentation/devicetree/bindings/media/nxp,imx8q-vpu.example.dt.yaml:0:
> 0: /example-0/vpu-bus@2c000000/vpu_encoder@2d0a0000: failed to match
> any schema with compatible: ['nxp,imx8q-vpu-encoder']
>=20
> See
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatch=
w
> ork.ozlabs.org%2Fpatch%2F1485530&amp;data=3D04%7C01%7Cming.qian%40n
> xp.com%7Ce1c1c81d4bf349f4551408d92501bba0%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C637581511648466898%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6Mn0%3D%7C1000&amp;sdata=3DUuQ%2Fc7p6ybq5AQPNjxUHRqYCImyKvVeY
> 9UQCfeiE94g%3D&amp;reserved=3D0
>=20
> This check can fail if there are any dependencies. The base for a patch s=
eries is
> generally the most recent rc1.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above error=
(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit.

Hi Rob,
   I have found the problem, I 'll fix it and re-submit soon