Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp508435pxj; Wed, 2 Jun 2021 04:56:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzL+0Ruo4Db2ViX/TT2nCnN0SlkRNzfaMH51si7/bErsnSPcmZbgzhGEmogIJMmWVXXkQW X-Received: by 2002:a05:6402:188:: with SMTP id r8mr37567082edv.75.1622635008147; Wed, 02 Jun 2021 04:56:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622635008; cv=none; d=google.com; s=arc-20160816; b=jowjgSYYlUewnZGiRrEaUbVFe2LsKM4htR16gu46Mwus60g2CjC6VYuaH3EVp3vo2f L0ydSHt0zj9+LQ32viQX8Vo7y9+AkI4yn22+slELNDbNfjZRIE2zK9951KC4MrA5xWyE LGqW7TY4rbrCFZxMbqjoRynyI4T6UXlDa6dZHzeKYSUxbZO/8I7QAl3YxLYn7E7Px0cg yu7VCwARWdGdCvcon/sMWR5UxudILOW2qH+SQngpUrWIr0gb4CR+yzjjzmMyN3RYcvoS spQDJWXHb5MKivUv2d3UQm+dedlyMAPX3/IQom9iiHVgUXX1TXwgbjKXXj2HNeY0qdpk 7bFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+9K0ZBY+cfWGtXy7iN7+32ZXUN6yO9gDst2tILKfNoQ=; b=xaRPErY+vX5QVApoA2Ra9FhIZbEo9Lnltvk7zc9Rg0CrWxpG7fz/Lw3ZZmXAJm7wJP lhSV4JFoLWoQUe7hohT3oIw8z9hquDifvA0Z4ghtjQ9mg0O/gzg7A0hdcTEQJPrvwCFe bYJGcuKJSi6+CTBcd06v0oHxxLZb9E9en+lYcDOWl4G1T0CPUPGgPKIKDLWxFJ8SgRr6 5FGbFbujqyuuM59SNkZUdmB6g1GMl9CwRA/RuiD7vc6vMpm5s3G0gco2OnPTDXZHnBIl f3wN8MQW/0iPzSdGvILbN+NWa3FSlsDao0SzGUI2qu73w8/ZT/JJgnQZuoSFKaIEphZR 9xWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=V2c4PKbH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si2625302ejo.417.2021.06.02.04.56.25; Wed, 02 Jun 2021 04:56:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=V2c4PKbH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbhFBKbR (ORCPT + 99 others); Wed, 2 Jun 2021 06:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbhFBKbQ (ORCPT ); Wed, 2 Jun 2021 06:31:16 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 626F4C061574 for ; Wed, 2 Jun 2021 03:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+9K0ZBY+cfWGtXy7iN7+32ZXUN6yO9gDst2tILKfNoQ=; b=V2c4PKbHUqXuQifwKnhHoE9Up RWm9TSqtCo4RaoK69ZNTIpW7ACz2ZxD2Iqm0SsouGhPHhWpregK4bJMbfHwIn6P0ltlHm9n+GDOZ1 BCHmpyw429bpvlFfIRXuhFlW028ZkbhmeqLgQGmFoTapN/74Jos1btVmzb2q4Nq5cG/VenX4Ats5K Yr6Naagv1cerHLzf4i2QeGQzFSGXhXSRMdq5zSl8FY3wxXaUeycntI+gW2A2AXIRha9DIqVA9Zds6 1EpGRaL2e4EBBc95xedLikzIlrna3hV66O49YFe1EHXzCWsFMvYtKZlEQ6i66b65MxRJ200i77ylj l2ZOUftbg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44610) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loO7t-0000yx-RU; Wed, 02 Jun 2021 11:29:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loO7t-00012M-4x; Wed, 02 Jun 2021 11:29:29 +0100 Date: Wed, 2 Jun 2021 11:29:29 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Subject: Re: [PATCH v2 1/7] ARM: mm: Rafactor the __do_page_fault() Message-ID: <20210602102929.GE30436@shell.armlinux.org.uk> References: <20210602070246.83990-1-wangkefeng.wang@huawei.com> <20210602070246.83990-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210602070246.83990-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jun 02, 2021 at 03:02:40PM +0800, Kefeng Wang wrote: > Clean up the multiple goto statements and drops local variable > vm_fault_t fault, which will make the __do_page_fault() much > more readability. > > No functional change. > > Signed-off-by: Kefeng Wang This looks fine to me. Please send it to the patch system (details in my email signature.) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!