Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp508634pxj; Wed, 2 Jun 2021 04:57:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3v+sjqdDBsokttKL3MaiwlOGXl227aoR97up2+crDfuvfHzOHdNvmksUUD96F5aLdHb8V X-Received: by 2002:a17:906:c0c6:: with SMTP id bn6mr32511101ejb.436.1622635028137; Wed, 02 Jun 2021 04:57:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622635028; cv=none; d=google.com; s=arc-20160816; b=Ct5hLbiXqG8f5IGoDPe9LPIoUxe+WQz6QujMevsY897PzHdSQ8uFe9W4MFO+dFGMQE bm0f8O+Sd1viiRWYsA9FeszstHpt9BOebhzygW9DJ1vg/axMjf0yD5OX67nb41jFfCTW O58vRampmGEQHTJ49psBds8Mw1kAiD1ePkLCICuNxTD07+xAQ9VOgubx8M3QfUD+Szay LLVQmOP5wmHELsJCSwLzP30+DZbcF9cZ2V51dYuPfOElsmmYqeDh42DpHCnskDyu60h+ 0jjHmBHM2zpdDyMDdx4MajqQMNpVjXEiohE8kRd6YHsZnfkSVvxUTp1FEZi9UXd4jFg0 E52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0SAzHmAT4S261rPuHMSSnq0NUaRVlh+m0eXDWd0+8YM=; b=o9jcUniOXtSnfXiiZvUfxS4yCFor49bNaWIhEi55ypBB88XTNtC4AAYA9N8YxStZTY Mcmt5Lysre9Gx+UteIpDr0Hq6EPLMF6Xb66q43cTC2R3WN2SD8wx0l9LncfmJZafNdqj Z796cl/Y86MAweTNURFJLejvWvMP9XqJ2uYUOQkP6n2TKtGoAXtfkASsjbUOpsfbsUuG HZ6A7Ui850TSLWGuigp+HKjKjgxaZp+lFTgRQ0OS8G0ZIAhZznZdmm+Jy/cNMjIR1/rj cC3Fc72Be9i7e706vnTwnCI0S+nQiI8n+LWaYSJjzwhYUvrCOjq5iSFx1vhcsl7PowY5 ecGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=f5uETbSu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bw25si8481320ejb.222.2021.06.02.04.56.45; Wed, 02 Jun 2021 04:57:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=f5uETbSu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232248AbhFBKcg (ORCPT + 99 others); Wed, 2 Jun 2021 06:32:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232698AbhFBKcU (ORCPT ); Wed, 2 Jun 2021 06:32:20 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00F63C06175F for ; Wed, 2 Jun 2021 03:30:38 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 6so1867658pgk.5 for ; Wed, 02 Jun 2021 03:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0SAzHmAT4S261rPuHMSSnq0NUaRVlh+m0eXDWd0+8YM=; b=f5uETbSu0slGWjnOwVuhzwPC2PeWII4nuiVKyGsySkKsiOlhCZVuLFaAmWRtGZ60sB YbIERc223XE3G01FEVHlcbj3rvS7//wS5itbOp97GGEsx0Kyr8ZGCk39CmYYLITMGLpV nCl7zxU+QNBhlW7OdD4Ys4A0pphOOYxKQf7Daxdc2Np8SYp5xnGCPYuv/ZeYfLVqrk5E xfkgOQyGpeaObgBXApw6mLViAj3nsLAy1d1FHBsJRJd9jA63q3/+MUjcJjQLPmtx5JaP Fz2fXM9j5S6jradPxmeQal2Ny+kaG8pUiHNyocTcrPYv9AjaZkNtix4iGYxkWLYyb8X2 pnaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0SAzHmAT4S261rPuHMSSnq0NUaRVlh+m0eXDWd0+8YM=; b=W2s5pE79u9feTaKlfblGz6Y+X6cpcZ9+wqO6p/MXv0jonYZQsad8Yvv32luQ7m0e0X DDGbimERK1QjnxqU4KbbaKhpd2TKaiZnPQi32Yri7h6uBnmFyEcWkBrMH3UOaEEiPCpm fFUKkYhp6IyOdkYImuYWtQCQLN4fQUk/4xsjzS0LLHl/vrTYzV/mdxC6L8574/3vt3cu fkGbeyjg2GIXti8SN8M9Rwnvw1R6HBrPUwSumPIWUe8NosLdeenQNBIH29wJBSzmuN6F 4rP1O012wVBHytQB3jLtSaxUS6x1oQjSJ++H4fLjFdsUTg0NOqs4B0aERQwIUR9GxDvG 9L0w== X-Gm-Message-State: AOAM532qWuZN3koX0zlOQmxBXrWVYmId6iPMFYe3JlV2k0CAvtYCjSm4 rLuOLuh+SXHQQvWO5nN43Rrv6w== X-Received: by 2002:a62:7587:0:b029:2e9:a997:1449 with SMTP id q129-20020a6275870000b02902e9a9971449mr20698327pfc.57.1622629837509; Wed, 02 Jun 2021 03:30:37 -0700 (PDT) Received: from localhost (ec2-18-167-84-74.ap-east-1.compute.amazonaws.com. [18.167.84.74]) by smtp.gmail.com with ESMTPSA id r10sm18379761pga.48.2021.06.02.03.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:30:37 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Adrian Hunter , Andi Kleen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v2 7/8] perf auxtrace: Use WRITE_ONCE() for updating aux_tail Date: Wed, 2 Jun 2021 18:30:06 +0800 Message-Id: <20210602103007.184993-8-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210602103007.184993-1-leo.yan@linaro.org> References: <20210602103007.184993-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use WRITE_ONCE() for updating aux_tail, so can avoid unexpected memory behaviour. Signed-off-by: Leo Yan --- tools/perf/util/auxtrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h index e625bc76cdde..abc4282f5272 100644 --- a/tools/perf/util/auxtrace.h +++ b/tools/perf/util/auxtrace.h @@ -458,7 +458,7 @@ static inline void auxtrace_mmap__write_tail(struct auxtrace_mmap *mm, u64 tail) /* Ensure all reads are done before we write the tail out */ smp_mb(); - pc->aux_tail = tail; + WRITE_ONCE(pc->aux_tail, tail); } int auxtrace_mmap__mmap(struct auxtrace_mmap *mm, -- 2.25.1