Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp508791pxj; Wed, 2 Jun 2021 04:57:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO8ig8V5JRir5rt13e9wSuWpU/mBWYD7uZgoEz8MHI60YQN2+uoiSS6RaXVThuwngK5XPA X-Received: by 2002:a05:6e02:1182:: with SMTP id y2mr4972175ili.20.1622635044181; Wed, 02 Jun 2021 04:57:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622635044; cv=none; d=google.com; s=arc-20160816; b=ZsE4J2f1m599Nwf/WWrR8VlTHDMQdEGtx1AOtrc5lS8LO2tZMFKgOSggRzj3q7L7Ps AScNMKB6Esg78f0/1CltWWdKZRAXTqgegAnPJi8js8Ew/bASae4Xri8xPdsTkzYbR8vX l5fZ+PNS6oErclPrwbn0zXKXXFKcF0LkLxZcLBS+EJJovtFk6mNeWq/gwzB+2HH+5BPe QMoL/nfUP/obbZ2M+8rjYKc3QFMKOuTYO27UORGu4ljdDnllZF+XuJ9IsVAdU5bLDqYh BiLfJCoEW17x9U9LIjCKljEzPI1NYwAiR9qgWm2J6vhnEaGjuuvUfg1Rres/+MR8gn40 CIJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=orFPAiLjT/TAscUeulOFNpz0N4+/FzjmvGEiheJyemc=; b=yvVH/5sGSAy7VmjOQZ5QxYTQBWahpEc9TxlQ7CKr7YoSA9MA1W+TvJbZyihDczjHXl 9mV8ePrVo9kchJmhNVPvB4z8q2mGyEkYruPxOawgfiVkDfgb8KmK6MzL/cDQZ/VxncaI UsHk7IXIb83USpXo2lBsCTejscBKTCajiASBPDgAu1kf88Sw+Q0QueG9sU2rPhNuBW3x n3NULPcbykL72vpet/UTQ80UqrRTwtCyCy5C+dbVRLfVlEMDukHqiyx+hN8UYQp4wmAT S/TPdlvX7YvL6z98WBgz+YAA/t0cI0H4cgFMYAElgzhZcFVQluL4hyRITt70BtVz26Ht iorg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CfSl7oh/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si21516543ils.142.2021.06.02.04.57.11; Wed, 02 Jun 2021 04:57:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="CfSl7oh/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232541AbhFBKcH (ORCPT + 99 others); Wed, 2 Jun 2021 06:32:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231934AbhFBKcD (ORCPT ); Wed, 2 Jun 2021 06:32:03 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B5C2C061574 for ; Wed, 2 Jun 2021 03:30:16 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id q16so877313pls.6 for ; Wed, 02 Jun 2021 03:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=orFPAiLjT/TAscUeulOFNpz0N4+/FzjmvGEiheJyemc=; b=CfSl7oh/E89fzWzOWN6rxS7VywjKuPgxegQFL/6aij7rHSk3GnslJv9+GgMZdvNiVO J8+S5CwfdSox/zeoLFWzo75pgfWY0Sfl9/OIMxMInHnf8laWqv+X3mGWQIgQPE8TMpMW CIGU2Vmh57hR0/NlbOG0P+rmvWZ1YrEaJK8nAlX5T35lgzvnkhcKnp4VPVciWTRLMxD3 H2hgzLpUBj0wooLg0aPzr1wlSO6R1Mx3MubPJlA2SNLbqDc9b6jTpwEF1aHZA67LME6p xOcgbAC9feDCfj1NdaDao4k5y9o35PEJtqqyk+OPcEpBRaQTHVDa2dAx3w7WXsw0DEGD lNGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=orFPAiLjT/TAscUeulOFNpz0N4+/FzjmvGEiheJyemc=; b=N6/rrt4xuE4Urr3GYk+UNmGKDLf9EGcfkauzOmGvKw/cIi93nRH1GGJytS03qY4MRR vdBKHYAlGKHHvvynCf5LgQjIyrNb8veitowscE9cEBd7+8oyyxiHdbyfJYRyn4msCuEV 3orjgCwMR8iT3ehwaWUDh3MRfRg3MWg4XAXrzOReUaI8k85RLoClyjnAX7q88SHhoWPa hvXNgCuMiy/lyUQ4yNDsXDHwGNBGzMh4PJkOOI0b2dS6KdDnbK2kconf/LDBAJwS0pve 2nAp8CI2TAg+nI1rqaDAlsFS6RIiy8JV+4nVUQ4EaNzwJ2lWVD6YZMry4mtGR3WhW2/p vaZA== X-Gm-Message-State: AOAM531hhnWgartRlzxDijyV8YTdg/mj8KpcnYSvrj0B6uZuCoM49G9r GuM7rT9A+4r9GR9AXc2E8w0c/g== X-Received: by 2002:a17:902:b10a:b029:f9:a0d:14a5 with SMTP id q10-20020a170902b10ab02900f90a0d14a5mr30455865plr.44.1622629815343; Wed, 02 Jun 2021 03:30:15 -0700 (PDT) Received: from localhost (ec2-18-167-84-74.ap-east-1.compute.amazonaws.com. [18.167.84.74]) by smtp.gmail.com with ESMTPSA id gg22sm4521060pjb.17.2021.06.02.03.30.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:30:14 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Adrian Hunter , Andi Kleen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v2 0/8] perf: Refine barriers for AUX ring buffer Date: Wed, 2 Jun 2021 18:29:59 +0800 Message-Id: <20210602103007.184993-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Based on the discussion [1], this patch series is to refine the memory barriers for AUX ring buffer. Patches 01 ~ 04 to address the barriers usage in the kernel. The first patch is to make clear comment for how to use the barriers between the data store and aux_head store, this asks the driver to make sure the data is visible. Patches 02 ~ 04 is to refine the drivers for barriers after the data store. Patches 05 ~ 07 is to fix and clean up the memory barries in perf tool for AUX ring buffer. Since the 64-bit value's atomicity is not promised on 32-bit perf, the last patch is to report error and let perf to directly exit for this case. Have testes the patches on Arm64 Juno platform. [1] https://lore.kernel.org/patchwork/patch/1431867/ Leo Yan (8): perf/ring_buffer: Add comment for barriers on AUX ring buffer coresight: tmc-etr: Add barrier after updating AUX ring buffer coresight: tmc-etf: Add comment for store ordering perf/x86: Add barrier after updating bts perf auxtrace: Change to use SMP memory barriers perf auxtrace: Drop legacy __sync functions perf auxtrace: Use WRITE_ONCE() for updating aux_tail perf record: Directly bail out for compat case arch/x86/events/intel/bts.c | 3 +++ .../hwtracing/coresight/coresight-tmc-etf.c | 6 +++++ .../hwtracing/coresight/coresight-tmc-etr.c | 8 ++++++ kernel/events/ring_buffer.c | 9 +++++++ tools/perf/builtin-record.c | 17 ++++++++++++ tools/perf/util/auxtrace.h | 27 +++---------------- 6 files changed, 47 insertions(+), 23 deletions(-) -- 2.25.1