Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH] net/mlx5e: Fix an error code in
 mlx5e_arfs_create_tables()
To:     Yang Li <yang.lee@linux.alibaba.com>, <saeedm@nvidia.com>
CC:     <leon@kernel.org>, <davem@davemloft.net>, <kuba@kernel.org>,
        <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1622628553-89257-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Mark Zhang <markzhang@nvidia.com>
Message-ID: <7b14006a-4528-bdd9-dd12-0785d8409a5d@nvidia.com>
Date:   Wed, 2 Jun 2021 19:49:19 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <1622628553-89257-1-git-send-email-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2021 11:49:25.1916
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b793e476-d033-4197-51a6-08d925bc785b
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT013.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5433
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/2/2021 6:09 PM, Yang Li wrote:
> When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0.
> So, we use -ENOMEM to indicate that the function
> create_singlethread_workqueue() return NULL.
> 
> Clean up smatch warning:
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
> mlx5e_arfs_create_tables() warn: missing error code 'err'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 'commit f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev when needed")'
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
> index 5cd466e..2949437 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
> @@ -369,8 +369,10 @@ int mlx5e_arfs_create_tables(struct mlx5e_priv *priv)
>   	spin_lock_init(&priv->fs.arfs->arfs_lock);
>   	INIT_LIST_HEAD(&priv->fs.arfs->rules);
>   	priv->fs.arfs->wq = create_singlethread_workqueue("mlx5e_arfs");
> -	if (!priv->fs.arfs->wq)
> +	if (!priv->fs.arfs->wq) {
> +		err = -ENOMEM;
>   		goto err;
> +	}
>   
>   	for (i = 0; i < ARFS_NUM_TYPES; i++) {
>   		err = arfs_create_table(priv, i);

Maybe also need to "destroy_workqueue(priv->fs.arfs->wq);" in err_des.