Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp572629pxj; Wed, 2 Jun 2021 06:22:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8oG0/qX6FLCwUBXVZB/oF7tfyjSWPF5TqbgHSVpia/oginrubsAZDLYgh0lcIYWYJX87U X-Received: by 2002:aa7:dbc9:: with SMTP id v9mr38608303edt.183.1622640165559; Wed, 02 Jun 2021 06:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622640165; cv=none; d=google.com; s=arc-20160816; b=uEQpww0PvA9Om55MNuev96ZJLoxSacFKeM5sWIaN2aYp35PwQjGCpj8uWsWALjRhge LbZ5pFznsu1YRwxBUvgEUaWzuNgtOMJ0W8tAMF2UbP8Gy+hnHkis53FOZN2MkcS6Fu0A /EOHlY5JllM9/wH4arw77xRAepp0kcMkIX8zVi3xuajbR6Ibrz2r/AyZWJiV56YFq2Yl LheCi4lAEDWXVBCyRwL4I223TNApaC7+K+8AchgS8vho95RoLB2tbfjHHq19NCjwdSpD ZioYA2rrMUOVx9uV3tfxEoL5jIw13KTMNH2PLr+PApwZbDQMOpQ6wqNCy+9z5G+6mbGX Cycg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=uH5yxU+BzRF90wWQwBO4VM5milL3akGJBti5j4uOIZE=; b=S9MXier2+YfI/oxD5VK625eqTCbs2adB/0AnQt94eo1R5Cn4uBzzNSDZaPKQgd4PAj +RCdpudo49x5BerjyI8LuTuecZ+wYBUnjUDA6Jf7U+l4YOE8UPi7eIVMZWl3jqWALFPs Bj86TCTZEBWotleIGZ2gbUnvNVi0xIbAEOLk1x7dd3iSVPrbSxXFYNUVPE5eRjTqajUL ZNoJGLpWg7/k36v8l4N/Rr57NyU/uxYIjcsdMUPMNPpKqPn6F2Gt5n6382+UA3z/CgHz WhB8c6Bk4RoOtJkJPbGRQEZGDwLHprC4cHhR8BrkV1FSDu4xNeEyVxXvMdQlQrhuIgZd ge/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s6OLJzCV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k16si1916660edo.475.2021.06.02.06.22.22; Wed, 02 Jun 2021 06:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s6OLJzCV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbhFBNTh (ORCPT + 99 others); Wed, 2 Jun 2021 09:19:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbhFBNTf (ORCPT ); Wed, 2 Jun 2021 09:19:35 -0400 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC26DC061574 for ; Wed, 2 Jun 2021 06:17:52 -0700 (PDT) Received: by mail-ua1-x936.google.com with SMTP id d13so567516uav.5 for ; Wed, 02 Jun 2021 06:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uH5yxU+BzRF90wWQwBO4VM5milL3akGJBti5j4uOIZE=; b=s6OLJzCVfowSoFK+Kn+Dhlq9dbdZvw299TRcMkIdw5Yuw3QzvKXt83rm00ZYmdAzHh /1dzY+TZZYI7BxQvrF0FDyUZF9EMiKzASt4L13dLl6SCkUavqGGqBrk3O90KyRB0h+lE 5vqtpcRDiNuA4hyi2GEWpaPREnpTT8jFXAL3Ypr8EXcRsTLjM2LEkV+hLkRG4wNmfK+c hawPsG2yo23cDzABvRJQmn8X+GmEu9mJER+1cYC3lQAxQ/foh9xbWloSO7ggqM4k6Djv ehNToKgNW35e/8OEm0Hun2TjV2n0awAldfNx1NCqo7S6PU2Wlxzae8ooaKznyMLri193 rSiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uH5yxU+BzRF90wWQwBO4VM5milL3akGJBti5j4uOIZE=; b=oP2Iv5xtml/3zc1sH28faC/3Z/j9jSzxb/xAhvWgUy5pQWi3x/7MJZSJWx2QpIB3rT TZBugGTp7zbsnsRljnksHoPAWjh1HZrb30FZu0r/NBv8DMQHuBbyji6rDo0KbhxuT34X LZ68/6ErS1tymG1MiiYSMv0AbMoTji7o6abtI0tDtDzi4Tfa0nMDTRlmOyfucVDhkmsM MykafjYNzWT5dnTEpADRQAlyL2Hgs+rsLKxoyHla/bvdqxzmcIVb/YZWdnQhkOlDgn9P x5sm42TBDAMQDeec01w0fmikzd3kxuZPVbfyRKKew70qFMtP/qaBKO23ChKCrSRLSkuM IR6A== X-Gm-Message-State: AOAM533nG3Xi8MHXO3nlE26XGzaKidi3mGRo9qRagZ9Lw2I1aJRScLW3 vY5PHOhOZfb8/pocEmSSpu1KM0EfQOtJ8B1PwZRkyg== X-Received: by 2002:ab0:100f:: with SMTP id f15mr21456136uab.100.1622639870335; Wed, 02 Jun 2021 06:17:50 -0700 (PDT) MIME-Version: 1.0 References: <20210602112321.2241566-1-anup.patel@wdc.com> <20210602112321.2241566-6-anup.patel@wdc.com> In-Reply-To: <20210602112321.2241566-6-anup.patel@wdc.com> From: Ulf Hansson Date: Wed, 2 Jun 2021 15:17:13 +0200 Message-ID: Subject: Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , Anup Patel , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Jun 2021 at 13:24, Anup Patel wrote: > > The generic power domain related code in PSCI domain driver is largely > independent of PSCI and can be shared with RISC-V SBI domain driver > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > Signed-off-by: Anup Patel Reviewed-by: Ulf Hansson A small nitpick below. [...] > +EXPORT_SYMBOL_GPL(dt_idle_pd_free); Do we really need to export this symbol? Looks like there are only built-in cpuidle drivers that are going to use it. At least for now. As a matter of fact, the same comment applies to all cases of EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them? [...] Kind regards Uffe