Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: SDMSRLklSO1j6akGRQWdo4pWitya20itBR4HYjO32wwuNTKvcshQ/0dBeKeYbQHqOeDvkgpHn8
 byu8K9QjJm/w==
IronPort-SDR: DbzsOULsi6zea7J8HpmDoYlaiiYgMPSZ3UyaXePMwK6kXJ/BQumGWmKOp/H5POh+E3pCS+R6pY
 G1NqnWBRgMKw==
Date:   Wed, 2 Jun 2021 18:47:27 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     gregkh@linuxfoundation.org, rafael@kernel.org,
        akpm@linux-foundation.org, jonathan.cameron@huawei.com,
        song.bao.hua@hisilicon.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] lib: bitmap: introduce bitmap_print_to_buf
Message-ID: <YLeoDzObZpJwDswB@smile.fi.intel.com>
References: <1622641734-22538-1-git-send-email-tiantao6@hisilicon.com>
 <1622641734-22538-2-git-send-email-tiantao6@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1622641734-22538-2-git-send-email-tiantao6@hisilicon.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jun 02, 2021 at 09:48:52PM +0800, Tian Tao wrote:
> New API bitmap_print_to_buf() with bin_attribute to avoid maskp
> exceeding PAGE_SIZE. bitmap_print_to_pagebuf() is a special case
> of bitmap_print_to_buf(), so in bitmap_print_to_pagebuf() call
> bitmap_print_to_buf().

...

> + * The role of cpumap_print_to_buf and cpumap_print_to_pagebuf is

 * The role of cpumap_print_to_buf() and cpumap_print_to_pagebuf() is

...

> + * The role of bitmap_print_to_buf and bitmap_print_to_pagebuf() is

 * The role of bitmap_print_to_buf() and bitmap_print_to_pagebuf() is

...

> +	int size;

Strictly speaking it should be ssize_t.

> +	void *data;
> +	const char *fmt = list ? "%*pbl\n" : "%*pb\n";

Can you use reversed xmas tree order?

...

> +	return bitmap_print_to_buf(list, buf, maskp, nmaskbits,
> +				   LLONG_MAX, len);

It fits one line.

-- 
With Best Regards,
Andy Shevchenko