Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 9/9] media: dwc: dw-hdmi-rx: Add support for CEC
To:     Nelson Costa <Nelson.Costa@synopsys.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jose Abreu <Jose.Abreu@synopsys.com>
References: <cover.1622631488.git.nelson.costa@synopsys.com>
 <86557797e979ce29ed97dd1ed0db8499a6ccbc34.1622631488.git.nelson.costa@synopsys.com>
 <746222a8-4b3f-2655-c5de-15d25e8b8852@xs4all.nl>
 <MW3PR12MB4459CED2A8E155673DCB6019C13D9@MW3PR12MB4459.namprd12.prod.outlook.com>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
Message-ID: <5ef03a9b-01b0-5401-9db1-65c5e9b24cea@xs4all.nl>
Date:   Wed, 2 Jun 2021 20:27:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <MW3PR12MB4459CED2A8E155673DCB6019C13D9@MW3PR12MB4459.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02/06/2021 20:20, Nelson Costa wrote:
> Hi Hans,
> 
> Thanks for your comments and feedback!
> 
> From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Date: qua, jun 02, 2021 at 13:45:45
> 
>> On 02/06/2021 13:24, Nelson Costa wrote:
>>> @@ -3194,10 +3428,29 @@ static int dw_hdmi_rx_probe(struct platform_device *pdev)
>>>  	if (ret)
>>>  		goto err_phy_exit;
>>>  
>>> +	/* CEC */
>>> +#if IS_ENABLED(CONFIG_VIDEO_DWC_HDMI_RX_CEC)
>>> +	dw_dev->cec_adap = cec_allocate_adapter(&dw_hdmi_cec_adap_ops,
>>> +						dw_dev, dev_name(dev),
>>> +						(CEC_CAP_DEFAULTS |
>>> +						 CEC_CAP_NEEDS_HPD |
>>
>> This cap makes no sense for a receiver.
>>
> 
> This cap was added in order to overcome a scenario that we have when 
> there
> was an hot plug. The driver performs a main reset that cause the loss of
> cec controller configuration. And in that case in order to reconfigure 

What do you mean with 'there was an hot plug'? Are you talking about the HPD
signal? Or when a new source/cable is connected? Can you point to the code
where that happens in the driver?

Regards,

	Hans

> the
> cec this cap was added. Because whenever there is a reset the physical
> address is reconfigured (invalidated and set) and with this cap the cec
> configuration callback function (adap_enable) is called again allowing to
> reconfigure the cec.
> 
> Does it make sense?
> 
> If not, what should be the best approach in order to deal with this 
> scenario?