Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 2 Jun 2021 14:29:50 -0500
From:   Rob Herring <robh@kernel.org>
To:     Heiko Schocher <hs@denx.de>
Cc:     linux-mtd@lists.infradead.org, Fabio Estevam <festevam@denx.de>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mtd: devices: add devicetree documentation for
 microchip 48l640
Message-ID: <20210602192950.GA3827845@robh.at.kernel.org>
References: <20210601043546.1345704-1-hs@denx.de>
 <20210601043546.1345704-2-hs@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210601043546.1345704-2-hs@denx.de>
Precedence: bulk

On Tue, Jun 01, 2021 at 06:35:45AM +0200, Heiko Schocher wrote:
> The Microchip 48l640 is a 8KByte EERAM connected via SPI.
> Add devicetree bindings documentation.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> 
> Changes in v3:
> Add Fabio to cc
> 
> Changes in v2:
> as Rob helped, fix warnings from running command
> 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> 
>  .../bindings/mtd/microchip,mchp48l640.yaml    | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> new file mode 100644
> index 0000000000000..08089f2db0761
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/mtd/microchip,mchp48l640.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: MTD SPI driver for Microchip 48l640 (and similar) serial EERAM

This is not the driver.

> +
> +maintainers:
> +  - Heiko Schocher <hs@denx.de>
> +
> +description: |
> +  The Microchip 48l640 is a 8KByte EERAM connected via SPI.
> +
> +  datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/20006055B.pdf
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: microchip,48l640
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      spi-eeram@0 {

eeram@0

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>


> +        compatible = "microchip,48l640";
> +        reg = <0>;
> +        spi-max-frequency = <20000000>;
> +      };
> +    };
> +...
> -- 
> 2.31.1