Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750890AbWKBRvJ (ORCPT ); Thu, 2 Nov 2006 12:51:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750991AbWKBRvJ (ORCPT ); Thu, 2 Nov 2006 12:51:09 -0500 Received: from mail.tmr.com ([64.65.253.246]:24028 "EHLO pixels.tmr.com") by vger.kernel.org with ESMTP id S1750890AbWKBRvI (ORCPT ); Thu, 2 Nov 2006 12:51:08 -0500 Message-ID: <454A2FC2.4060107@tmr.com> Date: Thu, 02 Nov 2006 12:49:54 -0500 From: Bill Davidsen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: Henrique de Moraes Holschuh CC: Shem Multinymous , David Zeuthen , Richard Hughes , David Woodhouse , Dan Williams , linux-kernel@vger.kernel.org, devel@laptop.org, sfr@canb.auug.org.au, len.brown@intel.com, benh@kernel.crashing.org, linux-thinkpad mailing list , Pavel Machek , Jean Delvare Subject: Re: [ltp] Re: [PATCH v2] Re: Battery class driver. References: <41840b750610251639t637cd590w1605d5fc8e10cd4d@mail.gmail.com> <1162037754.19446.502.camel@pmac.infradead.org> <1162041726.16799.1.camel@hughsie-laptop> <1162048148.2723.61.camel@zelda.fubar.dk> <41840b750610281112q7790ecao774b3d1b375aca9b@mail.gmail.com> <20061031074946.GA7906@kroah.com> <41840b750610310528p4b60d076v89fc7611a0943433@mail.gmail.com> <20061101193134.GB29929@kroah.com> <41840b750611011153w3a2ace72tcdb45a446e8298@mail.gmail.com> <20061101205330.GA2593@kroah.com> <20061101235540.GA11581@khazad-dum.debian.net> In-Reply-To: <20061101235540.GA11581@khazad-dum.debian.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2678 Lines: 65 Henrique de Moraes Holschuh wrote: > On Wed, 01 Nov 2006, Greg KH wrote: >> On Wed, Nov 01, 2006 at 09:53:12PM +0200, Shem Multinymous wrote: >>> Hi Greg, >>> >>> On 11/1/06, Greg KH wrote: >>>>> The suggestions so far were: >>>>> 1. Append units string to the content of such attribute: >>>>> /sys/.../capacity_remaining reads "16495 mW". >>>>> 2. Add a seprate *_units attribute saying what are units for other >>>>> attribute: >>>>> /sys/.../capacity_units gives the units for >>>>> /sys/.../capacity_{remaining,last_full,design,min,...}. >>>>> 3. Append the units to the attribute names: >>>>> capacity_{remaining,last_full,design_min,...}:mV. >>>> No, again, one for power and one for current. Two different files >>>> depending on the type of battery present. That way there is no need to >>>> worry about unit issues. >>> I'm missing something. How is that different from option 3 above? >> No silly ":mV" on the file name. > > As long as that also means no "silly _mV" in the name. However, if the > choice is between :mV and _mV, please go with :mV. > >>> BTW, please note that we're talking about a large set of files that >>> use these units (remaining, last full, design capacity, alarm >>> thresholds, etc.), and not just a single attribute. >> Sure, what's wrong with: >> capacity_remaining_power >> capacity_last_full_power >> capacity_design_min_power >> if you can read that from the battery, and: >> capacity_remaining_current >> capacity_last_full_current >> capacity_design_min_current >> if you can read that instead. > > Well, "Wh" measures energy and not power, and "Ah" measures electric charge > and not current, so it would be better to make that: > > capacity_*_energy (Wh-based) > > and > > capacity_*_charge (Ah-based) > > Also, should we go with mWh/mAh, or with even smaller units because of the > tiny battery-driven devices of tomorrow? > Having seen a French consultant with a Windows laptop reporting mJ (Joules) I bet that came from the hardware. And given that laptop batteries run at (almost) constant voltage, could all of these just be converted to mWh for consistency? -- Bill Davidsen Obscure bug of 2004: BASH BUFFER OVERFLOW - if bash is being run by a normal user and is setuid root, with the "vi" line edit mode selected, and the character set is "big5," an off-by-one errors occurs during wildcard (glob) expansion. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/