Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp957030pxj; Wed, 2 Jun 2021 16:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfjSyMxOd4vVBNRyp3/wnyFIH4nKyvVMHdLTRjENJYvEmYs6nerekMTyid4ww/jq1+JwKo X-Received: by 2002:a17:906:6bd8:: with SMTP id t24mr29789833ejs.501.1622676075420; Wed, 02 Jun 2021 16:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622676075; cv=none; d=google.com; s=arc-20160816; b=MxORoUdF++UrLcHqxvLsIa05t6A4Rid8IAMEZZ3DHKb4Wqh8Ubmog/g+cYrffpsyd1 xAERznJSNBuP+0DHn6UsdG9TRoOrDIAkWcJnrtzMsGAB+kWfDOkPbb7Q8sb125jcasoH SsTnQC1E8GdKgVHZQNvS+9jk7E2gPiznf1bxfEzgV34IDDciI68FpP6nTCye0/Yi66Ch 7FrbdgXZ6EF2Ui1ETHbqO3HEnWOdOGss5t0xfxpPFMa/vbKntWRBJLVSjNSh3UkwDw2c bNr9+5P0kv2duqrXRm2DE6/aPmp2kD/bz3JEFbbHV8CrJW6jtpjPw8KuVBs0yJhDIqoW 1W7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date; bh=zqex69WfVkOhBU9ZajH7dNpOt7vZ9l9Cp7EKghNQGLQ=; b=hcmIPVMtFMWydswi+miHJIkGbugrAgXeky+JigSlloAV08gpDSHI8kfWvLrpMVmNLF o0XtE2t/K7Tgg28U6mmD3wkbRjsjss6EIxVbs0niZ6HsFpYWvDlIknh/dXuu5F2Q4Wrl UllEHluq4vIsCoAsy8zEmKANe7Llw4xLYKD18R8dbz+63HrkQKpZs73Ppd956OW696+H /56Pu7yMb6BrN/5ea1/EWr6TWFjQaCiPbvZ1pYCjcI60598IKXSULKRHgnlp/2Vx5C97 68ywzMQ0uhek5fq/UcNc0SgmsXlBlb+hVbSvPnvTIdQDtXps6ztQonJlt7lIbHSYzoc/ q8rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gq9si800614ejb.720.2021.06.02.16.20.52; Wed, 02 Jun 2021 16:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbhFBXRq (ORCPT + 99 others); Wed, 2 Jun 2021 19:17:46 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:38376 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbhFBXRp (ORCPT ); Wed, 2 Jun 2021 19:17:45 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 466A4219DB; Wed, 2 Jun 2021 23:16:00 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 4AECA118DD; Wed, 2 Jun 2021 23:15:48 +0000 (UTC) Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id VMCuCCQRuGAfYQAALh3uQQ (envelope-from ); Wed, 02 Jun 2021 23:15:48 +0000 Date: Wed, 2 Jun 2021 16:15:42 -0700 From: Davidlohr Bueso To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , "Paul E. McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Subject: Re: [PATCH 2/6] sched: Introduce task_is_running() Message-ID: <20210602231542.ejrjbilfggq4whg7@offworld> Mail-Followup-To: Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , "Paul E. McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org References: <20210602131225.336600299@infradead.org> <20210602133040.334970485@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210602133040.334970485@infradead.org> User-Agent: NeoMutt/20201120 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Jun 2021, Peter Zijlstra wrote: >Replace a bunch of 'p->state == TASK_RUNNING' with a new helper: >task_is_running(p). > >Signed-off-by: Peter Zijlstra (Intel) Acked-by: Davidlohr Bueso But afaict .... >--- > arch/x86/kernel/process.c | 4 ++-- > block/blk-mq.c | 2 +- > include/linux/sched.h | 2 ++ > kernel/locking/lockdep.c | 2 +- > kernel/rcu/tree_plugin.h | 2 +- > kernel/sched/core.c | 6 +++--- > kernel/sched/stats.h | 2 +- > kernel/signal.c | 2 +- > kernel/softirq.c | 3 +-- > mm/compaction.c | 2 +- > 10 files changed, 14 insertions(+), 13 deletions(-) there are also (on top of the already mentioned arch/): kernel/kcsan/report.c: const bool is_running = current->state == TASK_RUNNING; kernel/locking/lockdep.c: if (p->state == TASK_RUNNING && p != current)