Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1032507pxj; Wed, 2 Jun 2021 18:50:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZSPawAUfxHAN5nJ52KIbRXPB0G30ur9r08ozGeaW80kn606hawQgsQ9uiHh/YCOTsYyo5 X-Received: by 2002:a05:6402:3585:: with SMTP id y5mr41866940edc.121.1622685012282; Wed, 02 Jun 2021 18:50:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622685012; cv=none; d=google.com; s=arc-20160816; b=hhEpfhr7IDhR0ujcE95rGYIb/+fNDNHFgrOcjla+2y074R4hraAOvW38eRlscHXyHW I+7gUYWMwmVlpXtwvpvGNFEL3dSdbr6FVMwZl/Czixu3cN3sJ1Rzfq5/aT631/nC099k 5Od6ETttMTLQaH1Bv8ifAdw9CXParFfFPUelVAlg6iXy+zqCL30i6WfEj2PWR7Nr7L5P ymXBcxL6jy843NezbeuqGgbrgkfU44wkxyRFEzZm/KDQwWMCl8sfQ+B1so6SSqf/OA51 ZHCgf68NdIc5JISWgDcGL5CrXu3wUlNLW9EKKTl2EwpoQWIG53oscUQjxdgB5bjzCECz BURg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=zefDGmtQIuLAcyAjzQIsragh0QsrVG7kr8gT95+SXIk=; b=JL5wUkeZBvCWsOmyYNRhzhdPSEWHJa/yZXocJfB60RPPcxhxSSoSsovqa1opq3cnXl Xz6dfJq1x/GGaJp0UCkZZVa9Jxg81mRpMmfosgCUN9LXGeLoIstk5FIR/Ay0PicwwCe0 3TrgK9UeFtfP2274QCe9E3wRFobUnicYsIyFldr+wcpO+SlXOsR7Wlc6S9/AMdgBOszh xsH7BmUfdz7chrj1IdjfpjL1JmAzbOh4zkfrKfky14NHw+zvbmx8fRq3pbYFcy7T+ug5 N3EnteHzFKVv8Hge/KnFRh5uwASpevdii6Iu1zxNSCUcutYrl9ULdOwGzPByts5ZJslg akbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si1319008ejy.157.2021.06.02.18.49.49; Wed, 02 Jun 2021 18:50:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbhFCBuE (ORCPT + 99 others); Wed, 2 Jun 2021 21:50:04 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7077 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhFCBuA (ORCPT ); Wed, 2 Jun 2021 21:50:00 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FwTHX2xqhzYqG6; Thu, 3 Jun 2021 09:45:28 +0800 (CST) Received: from dggpemm500005.china.huawei.com (7.185.36.74) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 09:48:13 +0800 Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 09:48:13 +0800 From: Yunsheng Lin To: , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH net-next v2 0/3] Some optimization for lockless qdisc Date: Thu, 3 Jun 2021 09:47:57 +0800 Message-ID: <1622684880-39895-1-git-send-email-linyunsheng@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch 1: remove unnecessary seqcount operation. Patch 2: implement TCQ_F_CAN_BYPASS. Patch 3: remove qdisc->empty. Performance data for pktgen in queue_xmit mode + dummy netdev with pfifo_fast: threads unpatched patched delta 1 2.60Mpps 3.21Mpps +23% 2 3.84Mpps 5.56Mpps +44% 4 5.52Mpps 5.58Mpps +1% 8 2.77Mpps 2.76Mpps -0.3% 16 2.24Mpps 2.23Mpps +0.4% Performance for IP forward testing: 1.05Mpps increases to 1.16Mpps, about 10% improvement. V2: Adjust the comment and commit log according to discussion in V1. V1: Drop RFC tag, Add nolock_qdisc_is_empty() and do the qdisc empty checking without the protection of qdisc->seqlock to aviod doing unnecessary spin_trylock() for contention case. RFC v4: Use STATE_MISSED and STATE_DRAINING to indicate non-empty qdisc, and add patch 1 and 3. Yunsheng Lin (3): net: sched: avoid unnecessary seqcount operation for lockless qdisc net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc net: sched: remove qdisc->empty for lockless qdisc include/net/sch_generic.h | 31 ++++++++++++++++++------------- net/core/dev.c | 27 +++++++++++++++++++++++++-- net/sched/sch_generic.c | 23 ++++++++++++++++------- 3 files changed, 59 insertions(+), 22 deletions(-) -- 2.7.4