Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Konrad Rzeszutek Wilk <konrad.r.wilk@gmail.com>
Date:   Wed, 2 Jun 2021 21:52:46 -0400
From:   Konrad Rzeszutek Wilk <konrad@darnok.org>
To:     Zheng Yongjun <zhengyongjun3@huawei.com>
Cc:     pjones@redhat.com, konrad@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ibft: Remove unneeded semicolon
Message-ID: <YLg17kKDiWEl7CF4@localhost.localdomain>
References: <20210601142132.4132319-1-zhengyongjun3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210601142132.4132319-1-zhengyongjun3@huawei.com>
Precedence: bulk

On Tue, Jun 01, 2021 at 10:21:32PM +0800, Zheng Yongjun wrote:
> Remove unneeded semicolon.

Heya,

Please bear with me - but this semicolon does not seem to be hurting
anyone so not sure what bug this patch is trying to fix?

I would prefer to leave the code as is (with all its warts) unless
there are bugs or features to be added.

Thank you.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  drivers/firmware/iscsi_ibft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 7127a04bca19..d46da640f484 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -802,7 +802,7 @@ static void ibft_unregister(void)
>  		ibft_kobj = boot_kobj->data;
>  		if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
>  			sysfs_remove_link(&boot_kobj->kobj, "device");
> -	};
> +	}
>  }
>  
>  static void ibft_cleanup(void)
> -- 
> 2.25.1
>