Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?ks_c_5601-1987?B?waTBvrnO?= <jjmin.jeong@samsung.com>
To:     "'Christoph Hellwig'" <hch@infradead.org>
Cc:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <cang@codeaurora.org>, <beanhuo@micron.com>,
        <adrian.hunter@intel.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: <YK9RkXoLsUT38cTP@infradead.org>
Subject: RE: [PATCH 1/3] scsi: ufs: add quirk to handle broken UIC command
Date:   Thu, 3 Jun 2021 12:08:57 +0900
Message-ID: <000001d75825$cb0ab5f0$612021d0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ks_c_5601-1987"
Content-Transfer-Encoding: 7bit
Thread-Index: AQIoW8PMwO5SDtoUto4XDMUWk4sZmgFpFnawAa5jbJkC4eUAGqovwbbQ
Content-Language: ko
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20210527030901.88403-1-jjmin.jeong@samsung.com>
        <CGME20210527031219epcas2p313fcf248833cf14ec9a164dd91a1ca13@epcas2p3.samsung.com>
        <20210527030901.88403-2-jjmin.jeong@samsung.com>
        <YK9RkXoLsUT38cTP@infradead.org>
Precedence: bulk

> > samsung ExynosAuto SoC has two types of host controller interface to
> > support the virtualization of UFS Device.
> > One is the physical host(PH) that the same as conventaional UFSHCI,
> > and the other is the virtual host(VH) that support data transfer
> function only.
> 
> You forgot to include the hunk that actually sets the quirk.

thanks for your review.
We will set up the quirk in exynos ufs driver.
I will upload the patch together in v2 patchs.

> 
> Also please work on the commit log formatting.

I'll erase the change-id log next patch too. Thank you.

> 
> > Change-Id: Ie528726b29bcb643149440bf1c90eaa5995c5ac1
> 
> This kind of crap has no business in a commit log.

Best Regards,
Jongmin jeong