Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp32409pxj; Wed, 2 Jun 2021 23:37:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy24kKH7dL5IlZGpXvWb1CLuklw9GYnuTMC4ieFABOHVMT4DFlo6D9s7VCDq6ov6vjzfKDl X-Received: by 2002:a05:6402:5193:: with SMTP id q19mr41945516edd.167.1622702244981; Wed, 02 Jun 2021 23:37:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622702244; cv=none; d=google.com; s=arc-20160816; b=FPtE73oaLzsjwxG9ArZ9rPf5hhobyLhAKwdx8amBCmVbj+DoxW1RZuBv5tBWRsFShK uDQmRrCpFAsoy72NI0xfa/7bHWrlq5nTe7cUPMjB5FYjJ3c6IM5Yo/8xwvVrQuseYZZD KsqOKefDUYgHkero18f1LH52jBS0xdU16TJNCled4dGHXRgm1dRQR5bl3deyvK9Ot5tU iYxM2srL8ShH65QCqAOTCjltNzBWMU2qTaPl9i7rV4lLpEDlyN39JDoEF3Dq44XloG34 WAssZgHKfjbm4mBGJJL+q4zqq8JWtqMArJyxWROAPV/+St/F9wK7CDjiaqN313MhnN+9 FspQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ACjtTzNZ3zVUo+4rvX+NvPCzvI/Diwp1X17DZ793eaA=; b=qmXvnEKfmrq6kGSeEbOEZLwj66UZpzatTyhqj1mSFcuRpmoJH+mS9NQtJETD+0LsRy GQjm5gNqcl/8ylyfmPEkfiiug06q8khrZvPNwSHDDvhDimCUYGuRUkEakIsVogvhcyU0 Op5jnfq1+NmDGjg+LJsDxPFQPn05Bc6zCfs9mdgSslLsR9MTbQpA00QVUkVyyCd3s96l QBcir39JgrwcOHhJrqUf7/yhek7tooRpCBG/GUh2DeV1JNgi5mQ7U6QNpX0aghrufYfV 3391+LDeIG+abEokgs5iHUUN85fvKRwcionea9ONbIuRPigEIGS4AOWArITBe9CHw2mc mnLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FbKLFDw2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 2si1981976edw.66.2021.06.02.23.37.01; Wed, 02 Jun 2021 23:37:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FbKLFDw2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbhFCGhB (ORCPT + 99 others); Thu, 3 Jun 2021 02:37:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41711 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbhFCGhA (ORCPT ); Thu, 3 Jun 2021 02:37:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622702116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACjtTzNZ3zVUo+4rvX+NvPCzvI/Diwp1X17DZ793eaA=; b=FbKLFDw2ou3yU8HuChl+gjVjZcEGL6f3IR/r8BvOfh3h/Gw+q809+Y5+y5jLO21BIJ2/nN hULrj6OCS4nZIYFrj2NYL7qLgZA8/ffF+vFFbprVyJ2HRSVp28U1Z8l4eFGPKGNL0+67b4 4RCeno9OxVZdb/dDAvz6pjZDhzPdFgQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-78daRXsXOeGsu0FPYaARXg-1; Thu, 03 Jun 2021 02:35:12 -0400 X-MC-Unique: 78daRXsXOeGsu0FPYaARXg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D4B1106BB37; Thu, 3 Jun 2021 06:35:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC6D75D74B; Thu, 3 Jun 2021 06:35:09 +0000 (UTC) From: =?UTF-8?q?=C3=8D=C3=B1igo=20Huguet?= To: rajur@chelsio.com, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ivecera@redhat.com, =?UTF-8?q?=C3=8D=C3=B1igo=20Huguet?= Subject: [PATCH 2/2] net:cxgb3: fix code style issues Date: Thu, 3 Jun 2021 08:34:30 +0200 Message-Id: <20210603063430.6613-2-ihuguet@redhat.com> In-Reply-To: <20210603063430.6613-1-ihuguet@redhat.com> References: <20210603063430.6613-1-ihuguet@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Íñigo Huguet --- .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 84ad7261e243..57f210c53afc 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -1273,14 +1273,14 @@ static int cxgb_up(struct adapter *adap) free_irq(adap->msix_info[0].vec, adap); goto irq_err; } - } else if ((err = request_irq(adap->pdev->irq, - t3_intr_handler(adap, - adap->sge.qs[0].rspq. - polling), - (adap->flags & USING_MSI) ? - 0 : IRQF_SHARED, - adap->name, adap))) - goto irq_err; + } else { + err = request_irq(adap->pdev->irq, + t3_intr_handler(adap, adap->sge.qs[0].rspq.polling), + (adap->flags & USING_MSI) ? 0 : IRQF_SHARED, + adap->name, adap); + if (err) + goto irq_err; + } enable_all_napi(adap); t3_sge_start(adap); @@ -3098,8 +3098,9 @@ static void set_nqsets(struct adapter *adap) nqsets = num_cpus; if (nqsets < 1 || hwports == 4) nqsets = 1; - } else + } else { nqsets = 1; + } for_each_port(adap, i) { struct port_info *pi = adap2pinfo(adap, i); -- 2.31.1