Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Jun 2021 08:33:50 +0200
From:   Michael Tretter <m.tretter@pengutronix.de>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     linuxarm@huawei.com, mauro.chehab@huawei.com,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 3/6] media: allegro-dvt: avoid EN DASH char
Message-ID: <20210603063350.GB12967@pengutronix.de>
Mail-Followup-To: Michael Tretter <m.tretter@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linuxarm@huawei.com, mauro.chehab@huawei.com,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
References: <cover.1622646256.git.mchehab+huawei@kernel.org>
 <94f20b3817342ace2ac06057150b73996874c43f.1622646256.git.mchehab+huawei@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <94f20b3817342ace2ac06057150b73996874c43f.1622646256.git.mchehab+huawei@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, 02 Jun 2021 17:05:20 +0200, Mauro Carvalho Chehab wrote:
> While there's nothing wrong with EN DASH on C code, this probably
> came from some cut-and paste from an ITU-T table.
> It sounds better to just an HYPHEN here.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  drivers/media/platform/allegro-dvt/nal-h264.c | 2 +-
>  drivers/media/platform/allegro-dvt/nal-hevc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/nal-h264.c
> index 94dd9266d850..a02095eb3fcf 100644
> --- a/drivers/media/platform/allegro-dvt/nal-h264.c
> +++ b/drivers/media/platform/allegro-dvt/nal-h264.c
> @@ -25,7 +25,7 @@
>  #include "nal-rbsp.h"
>  
>  /*
> - * See Rec. ITU-T H.264 (04/2017) Table 7-1 – NAL unit type codes, syntax
> + * See Rec. ITU-T H.264 (04/2017) Table 7-1 -- NAL unit type codes, syntax

This should be a single instead of a double hyphen.

With that fixed

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

Michael

>   * element categories, and NAL unit type classes
>   */
>  enum nal_unit_type {
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/nal-hevc.c
> index 5db540c69bfe..15a352e45831 100644
> --- a/drivers/media/platform/allegro-dvt/nal-hevc.c
> +++ b/drivers/media/platform/allegro-dvt/nal-hevc.c
> @@ -25,7 +25,7 @@
>  #include "nal-rbsp.h"
>  
>  /*
> - * See Rec. ITU-T H.265 (02/2018) Table 7-1 – NAL unit type codes and NAL unit
> + * See Rec. ITU-T H.265 (02/2018) Table 7-1 - NAL unit type codes and NAL unit
>   * type classes
>   */
>  enum nal_unit_type {
> -- 
> 2.31.1
> 
>