Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp44400pxj; Thu, 3 Jun 2021 00:01:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiQphPCp6m8j3KlVjYmFAhX81gBHUhrhzChoVBgox5mecIGWbQLS3sCfBkOJss3pxzMsIb X-Received: by 2002:a17:906:7ce:: with SMTP id m14mr5412526ejc.444.1622703684062; Thu, 03 Jun 2021 00:01:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622703684; cv=none; d=google.com; s=arc-20160816; b=XcEYx2FQsphZFMTaUfpGiK8EUUyLKzd4muBNCmFWIeUc4NXgI7JVqoNIePLYcquYn+ KgC5FLr4oM8/c3TV74WrdgTO2bFZlHXs3MCze86eIZelGFrlqBBjYutpf+MCqvdWsqER sv0L+ryMtQdc1LJoog0U7HmL6VrWPNVEJLG1lqY+B/+srSuzvqAeySspXFV3ZFGn5hIg 0/TMi8/Tv67WCgRa6hU868IL26eJeYpCLjAjnJatsFFm/hJKsiYYez1I6MQBjz8aOM1D uHnqDmQYaZuDxBCHNML3N79HCcJMUGTjFs77LgqyzmxIi4c9boOr+EEEo+dskIyWCWj7 2WGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m+5KaTiBWuLu3Op1D1Q4rPy6AYh3OViJ70gCR8Tr5to=; b=p25v9TNGFn0csyu5RrA9797v3UchQj0QgbWpw7uUtIvrDpJAIeZ14Nz+GWTKbDOEYx /pJyjSCLvpV1W58Gy+k2GRrVWJfhMcME6B2TwvbUzQfgO7930Ki4hJ+MKN56HZgkuPev PvAslPoM5yAqH1qdBDWAqazANCNMp4iwxhB5trpO5og0NM9UqB5RfmwLZW5tM/ypP/mN 6pjNDIE1e6mkmf7bYojHy/mXZl2Dx+A5WbO3w8t2p9gXsJYXM1/csWFSQQLx0OFmafkE 3sBsJsAZc8KYp0ZJBMAEz1GergsbW3401gWZDhF+TSGqHKrTIhwxu7lB8EhEHA17TDl6 LROA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KpKUW+yw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y10si1736975ejh.531.2021.06.03.00.01.01; Thu, 03 Jun 2021 00:01:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KpKUW+yw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbhFCHAz (ORCPT + 99 others); Thu, 3 Jun 2021 03:00:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:49014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhFCHAz (ORCPT ); Thu, 3 Jun 2021 03:00:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 390EB613DC; Thu, 3 Jun 2021 06:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622703551; bh=jgrGqdnGPl0lwpmF25TNhq9uPU4zSNlD7KMcq6t6+64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KpKUW+ywUIK57T5P7f5EqeOA4x9bGC1zroG5/AL+hkXJqKH4eKzKM4d6Ojw/HjyZW ZMSJSq8Vrs7I7+T2Zzq6JCC0vhHu7bMIWdqR9gMyF7GbRsUuJCAQax800CH0nRep48 YUB8zitsdijF9U5mTjOSuCJC5pen9gL57s+BX7srYZ8AXgwPl1/qe3LK/dFoDat5W6 dm+hj6G+SnnjtJVuZ3ZJ/Dz4XBz29IYvQwSKxf47AEZ9YaX8Q+vsz+CuDXnGcH3AqK BYbTpvynDSOZAS+EuDnxHNvPG3siDZvGRcWieJFxgvil2vsALg12/alz0+R+/Ca6LX cN6B31noO2Bhw== Date: Thu, 3 Jun 2021 12:29:07 +0530 From: Vinod Koul To: Jiapeng Chong Cc: dave.jiang@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: Fix missing error code in idxd_cdev_open() Message-ID: References: <1622628446-87909-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622628446-87909-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-06-21, 18:07, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'rc'. > > Eliminate the follow smatch warning: > > drivers/dma/idxd/cdev.c:113 idxd_cdev_open() warn: missing error code > 'rc'. Applied, thanks -- ~Vinod