Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] ieee802154: fix error return code in
 ieee802154_add_iface()
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        Alexander Aring <alex.aring@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wpan <linux-wpan@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20210508062517.2574-1-thunder.leizhen@huawei.com>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
Message-ID: <03320214-828c-4ac8-0fb8-89bd78b85c97@datenfreihafen.org>
Date:   Thu, 3 Jun 2021 10:53:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210508062517.2574-1-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello.

On 08.05.21 08:25, Zhen Lei wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: be51da0f3e34 ("ieee802154: Stop using NLA_PUT*().")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>   net/ieee802154/nl-phy.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/nl-phy.c b/net/ieee802154/nl-phy.c
> index 2cdc7e63fe17..88215b5c93aa 100644
> --- a/net/ieee802154/nl-phy.c
> +++ b/net/ieee802154/nl-phy.c
> @@ -241,8 +241,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct genl_info *info)
>   	}
>   
>   	if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) ||
> -	    nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name))
> +	    nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) {
> +		rc = -EMSGSIZE;
>   		goto nla_put_failure;
> +	}
>   	dev_put(dev);
>   
>   	wpan_phy_put(phy);
> 

Good find. We could indeed hit a case where the IEEE802154_ATTR_HW_ADDR 
attribute is present and rc would be assigned 0 before reaching this 
goto nla_put_failure

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt