Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Jun 2021 11:17:00 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Jiabing Wan <wanjiabing@vivo.com>
Cc:     Fabio Aiuto <fabioaiuto83@gmail.com>,
        Ross Schmidt <ross.schm.dev@gmail.com>,
        Qiang Ma <maqianga@uniontech.com>,
        Marco Cesati <marcocesati@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix some incorrect type
 warnings
Message-ID: <YLieDLLcsTctEwXD@kroah.com>
References: <1622708703-8561-1-git-send-email-wanjiabing@vivo.com>
 <AO6AtgBODjnoS0IYaAQ1bKoy.3.1622709415201.Hmail.wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AO6AtgBODjnoS0IYaAQ1bKoy.3.1622709415201.Hmail.wanjiabing@vivo.com>
Precedence: bulk

On Thu, Jun 03, 2021 at 04:36:55PM +0800, Jiabing Wan wrote:
>  
>  
> Hi,all
> 
> I fix these warnings by refering other patches.
> 
> Actually, I don't understand clearly what I did.  
> 
> But there are no warnings after this fix.
> 
> So if this fix were totally wrong, please told me and 
> gave me some suggestions.
> 
> It is important for me to fix a sparse bug.

Do not fix sparse bugs just for the sake of fixing sparse bugs.  Fix
things you know are needed to be fixed.

Please look closer at this to ensure that you really are fixing this
correctly and understand what you are doing before sending it out.

thanks,

greg k-h