Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210603093809.1108629-1-axel.lin@ingics.com> <1622715641.1034.5.camel@richtek.com>
 <CAFRkauDs6nyuboPBf9Q-=KDFkSjwQ4z9mDjzm3o95uzdu5bKCw@mail.gmail.com> <1622716902.1034.15.camel@richtek.com>
In-Reply-To: <1622716902.1034.15.camel@richtek.com>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Thu, 3 Jun 2021 18:57:53 +0800
Message-ID: <CAFRkauC2qugUBbHccf6jV=e_xRLAJP0JyPsFMzmTQO5KUaj=Qg@mail.gmail.com>
Subject: Re: [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap
To:     =?UTF-8?B?Y3lfaHVhbmco6buD5ZWf5Y6fKQ==?= <cy_huang@richtek.com>
Cc:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

cy_huang(=E9=BB=83=E5=95=9F=E5=8E=9F) <cy_huang@richtek.com> =E6=96=BC 2021=
=E5=B9=B46=E6=9C=883=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=886:41=E5=
=AF=AB=E9=81=93=EF=BC=9A
>
> > cy_huang(=E9=BB=83=E5=95=9F=E5=8E=9F) <cy_huang@richtek.com> =E6=96=BC =
2021=E5=B9=B46=E6=9C=883=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=886:20=
=E5=AF=AB=E9=81=93=EF=BC=9A
> > >
> > >
> > > Hi, Axel:> Use regulator_set_ramp_delay_regmap instead of open-coded.
> > > >
> > > >
> > > There's some reason.
> > > You can refer to https://lkml.org/lkml/2021/6/1/1145.
> > >
> > > It's because our ramp value order is from small to large, not large t=
o
> > > small.
> > > It conflicts with find_closest_bigger value chosen logic.
> > I have verified the rt6160_set_ramp_delay() behavior exactly the same a=
s
> > regulator_set_ramp_delay_regmap. (both functions get the same selector
> > for a given delay)
> >
> > Could you check if this patch works?
> Sure.

The find_closest_bigger() does not rely on ascending or descending
table entries.
Regards,
Axel