Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp180527pxj; Thu, 3 Jun 2021 04:09:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBSUqaOtLueCXlpQojs9BKhpNaFLj7uycqnRXYLPgIj90kC5yUSxSlL+wSqYTktcUx25dt X-Received: by 2002:a17:906:4109:: with SMTP id j9mr10881856ejk.250.1622718581039; Thu, 03 Jun 2021 04:09:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622718581; cv=none; d=google.com; s=arc-20160816; b=An1cCok9Y03wQBXAr2Rjw7Ejx8JwQpmmx18WRIlNt7MpESuyhRzLi2BiQxnjmSCNbk 9ztTk8IUbvcQ9/Ni7raeMXUBf3AqcAqDdu66EgxVz50MMCB5vGf6Dzg4hKoTVz1kD5nb iodiQGMwtrQnMUMgR0FCbMRESbXcFbgWU5zprMhrSKbt8CuLYcoxGKO4AKtdY9C0K8A+ sgqOJ/avmOrSDwaz0ZjFVJfFwZvHjwGWI6IHaLWuy3DygFT29NvX/YMaf/sr7BZ1lyf5 h6GLb9rQh4r9j2XxMGxKX5LHZ6tq5ALNMswZFacGRaQ+Y4z8ZvtZiNffAgQGhpZysa2S +GEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2HbRqGz7gNS3dD+U1OTNF2WEEhvWGTf02b4yiI8lSVs=; b=j+FF2We/Mnq/x20H28mZ/4n9zYl3ssukOGV8NjsHpqQs3A3ErMVUVarcB/qhFdKTaF rRBSLCAibm5cz0hXijPAXfBYp8fpAAS1l3cgG7MUqAVapip+ySZ+y8p+DrxsHHWowpRQ Wj/fxtdToEuvflMS2haI61vJa6IfaJ2gF6bX2DP0D/6VnAdAz8KtMl2GhILmW89CFPPG 6Dv1VqTfB8UYr8nGnKJg1MgHtqHGAjPx0Gv/G1uIRNcV2hSrOs1bON0JRCrLoxkHLZSc uoe27MJZFUnvyG/rMG18+E3ZeA6+7l0zaTgU28pcmEOqZllnisE4TJttCm6pmhitNKVG 2jzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K8TVXqaw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n5si2077679edr.505.2021.06.03.04.09.17; Thu, 03 Jun 2021 04:09:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K8TVXqaw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbhFCLJm (ORCPT + 99 others); Thu, 3 Jun 2021 07:09:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:33752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhFCLJm (ORCPT ); Thu, 3 Jun 2021 07:09:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5DC09613D7; Thu, 3 Jun 2021 11:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622718477; bh=f4K5JWhbtxnt2GNMNdWE8aEyOnpUw3O1MWjxYMBbEFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K8TVXqawAQgHdbdZw+m67cZ6I5igyM+svwdaRgkzGO9Afs7/5Nkk1XHtm/0bFlMKY MqIZtIskyIpXA1wf8UAh/qBEjBKMYwJrF6Nsr9gIxsLtWP9B2AZLrcYKH81LBnDaRv /i+i0B3qIecGs46LUrju5XEFKv3Rjzjwf0PXQFeEc95WLWF8mO3mYY9rzVZrv3Ruhf AC/MuAJpOekC9FwDMn4CypOLosf8cmwmrNYzAKAWZe4Xjucdgn5aWCx0fZNWq+QYId 5X43Ew/txa80+VhzsSUb7M/oWzjRN8VQBzaEl/SoM/ygfRQrOd9Eow/O0rgYQHrQOj 9KdjkH3Jh07Tg== Date: Thu, 3 Jun 2021 16:37:53 +0530 From: Vinod Koul To: Zou Wei Cc: yoshihiro.shimoda.uh@renesas.com, geert+renesas@glider.be, wsa+renesas@sang-engineering.com, laurent.pinchart@ideasonboard.com, robin.murphy@arm.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Message-ID: References: <1622442963-54095-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622442963-54095-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31-05-21, 14:36, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Applied, thanks -- ~Vinod