Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Jun 2021 08:29:58 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Andi Kleen <ak@linux.intel.com>
Cc:     syzbot <syzbot+84fe685c02cd112a2ac3@syzkaller.appspotmail.com>,
        bp@alien8.de, hpa@zytor.com, inglorion@google.com,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
        x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>
Subject: Re: [syzbot] KASAN: stack-out-of-bounds Read in profile_pc
Message-ID: <20210603132958.3es4xagwdijmzpqh@treble>
References: <00000000000030293b05c39afd6f@google.com>
 <20210602230054.vyqama2q3koc4bpo@treble>
 <527ad07e-eec2-a211-03e7-afafe5196100@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <527ad07e-eec2-a211-03e7-afafe5196100@linux.intel.com>
Precedence: bulk

On Wed, Jun 02, 2021 at 04:35:11PM -0700, Andi Kleen wrote:
> 
> > profile_pc() assumes the return address is either directly at regs->sp,
> > or one word adjacent to it due to saved flags, both of which are just
> > completely wrong.  This code has probably never worked with ORC, and
> > nobody noticed apparently.
> 
> I presume it used to work because the lock functions were really simple, but
> that's not true anymore.

Yeah, I figured as much.

> > We could just use ORC to unwind to the next frame.  Though, isn't
> > /proc/profile redundant, compared to all the more sophisticated options
> > nowadays?  Is there still a distinct use case for it or can we just
> > remove it?
> 
> It's still needed for some special cases. For example there is no other
> viable way to profile early boot without a VM
> 
> I would just drop the hack to unwind, at least for the early boot profile
> use case locking profiling is usually not needed.

Ok, I'll just get rid of the hack then.

-- 
Josh