Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Jun 2021 08:39:14 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Andi Kleen <ak@linux.intel.com>,
        syzbot <syzbot+84fe685c02cd112a2ac3@syzkaller.appspotmail.com>,
        bp@alien8.de, hpa@zytor.com, inglorion@google.com,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
        x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [syzbot] KASAN: stack-out-of-bounds Read in profile_pc
Message-ID: <20210603133914.j2aeadmvhncnlk5q@treble>
References: <00000000000030293b05c39afd6f@google.com>
 <20210602230054.vyqama2q3koc4bpo@treble>
 <527ad07e-eec2-a211-03e7-afafe5196100@linux.intel.com>
 <YLjZYvXnuPnbXzOm@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YLjZYvXnuPnbXzOm@hirez.programming.kicks-ass.net>
Precedence: bulk

On Thu, Jun 03, 2021 at 03:30:10PM +0200, Peter Zijlstra wrote:
> On Wed, Jun 02, 2021 at 04:35:11PM -0700, Andi Kleen wrote:
> 
> > > We could just use ORC to unwind to the next frame.  Though, isn't
> > > /proc/profile redundant, compared to all the more sophisticated options
> > > nowadays?  Is there still a distinct use case for it or can we just
> > > remove it?
> > 
> > It's still needed for some special cases. For example there is no other
> > viable way to profile early boot without a VM
> > 
> > I would just drop the hack to unwind, at least for the early boot profile
> > use case locking profiling is usually not needed.
> 
> Surely we can cook up something else there and delete this thing? ftrace
> buffers are available really early, it shouldn't be hard to dump some
> data in there during boot.

True, ftrace does have function profiling (function_profile_enabled).

Steve, is there a way to enable that on the kernel cmdline?

-- 
Josh