Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp359070pxj; Thu, 3 Jun 2021 08:25:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwczfNtWBRdjdzoevqO2PRwLiWdLidTvbDXjLCLk8e4KFoK0pJ4RmSUch4zDhFgAfVJsGXK X-Received: by 2002:aa7:db49:: with SMTP id n9mr6235edt.361.1622733934220; Thu, 03 Jun 2021 08:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622733934; cv=none; d=google.com; s=arc-20160816; b=Z+SK/b6fP6HyEr0EzUdX9jdu1sKVRDPnKnLjxPUg1Y+ctTkv1+gDErsr8Bbb62GyJh FTX13X4nUjrhW8xkbccOLOTqoKnAFdxNg9mwWMTCZAMqpWJTqM1Wd2BTjUZtb8cXjnTo EeanplQKslKvDbdyKApMY5vm5StOS19jHjQmklSBBuXm9unbBwYg7+dD0+33tQOCBj7H bn/tMgJHEe6+DrF5WOgKFcTaCSeNKaEnkmJq0FqKzJprQ7XIbDk7rPO6zry1uks6zycc pP0kbghmB+cYDukaJd8m/ZbzfVEJnNuGEX3GBX9NhlyeFdQra1OsP+yULwjhq9X9XcX7 htsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=p9Mpinrr6tiRqES1cJ2/HZ7HnNdA7fXjAcoTkTiWsYo=; b=Vj+hZmzC6NqOlCTWV7sSn9L/Sp1Omuh/XQu1zLNg/4P0v0TLrRBDH4uI+DJWRCq0SY AjEYxUf64e1pitDsYdSNYytpvbz8BNZwu7DnKiaGEd7zTGxD+Uz6izHkL6YWseCxIfCW jNxiGv7+NMy+9cp8hCS566AuRkmeXmYiAQQLx32T9aWQXxfCSSEySZxig+oFXDIoA2OZ cvCp+uZ8cxhPOVz3kz0m8sF1Sq8ms7mxeKNT4eKuhNk8i9UtSuP+2/mm8li+PyI6M3lA oNHFwXhcBcvQEZq1QUoGvoh7mHxXKTNSt3FSFc+FTw0w3i10uLjiS9/ycEe9g6ocZ8Ty AVOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t8si2326783edr.491.2021.06.03.08.25.10; Thu, 03 Jun 2021 08:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232043AbhFCPZb (ORCPT + 99 others); Thu, 3 Jun 2021 11:25:31 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7096 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231826AbhFCPZ3 (ORCPT ); Thu, 3 Jun 2021 11:25:29 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FwqNS51MqzYpD7; Thu, 3 Jun 2021 23:20:56 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 23:23:42 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 23:23:41 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next] scsi: mpi3mr: Fix missing unlock on error Date: Thu, 3 Jun 2021 23:28:03 +0800 Message-ID: <20210603152803.717505-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Goto unlock path before return from function in the error handling case. Fixes: c9566231cfaf ("scsi: mpi3mr: Create operational request and reply queue pair") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/scsi/mpi3mr/mpi3mr_fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c index dbf116414855..8aea1c2ae712 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c @@ -1583,7 +1583,7 @@ static int mpi3mr_create_op_reply_q(struct mpi3mr_ioc *mrioc, u16 qidx) if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) { retval = -1; ioc_err(mrioc, "CreateRepQ: Init command is in use\n"); - goto out; + goto out_unlock; } mrioc->init_cmds.state = MPI3MR_CMD_PENDING; mrioc->init_cmds.is_waiting = 1; @@ -1692,7 +1692,7 @@ static int mpi3mr_create_op_req_q(struct mpi3mr_ioc *mrioc, u16 idx, if (mrioc->init_cmds.state & MPI3MR_CMD_PENDING) { retval = -1; ioc_err(mrioc, "CreateReqQ: Init command is in use\n"); - goto out; + goto out_unlock; } mrioc->init_cmds.state = MPI3MR_CMD_PENDING; mrioc->init_cmds.is_waiting = 1; -- 2.25.1