Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ipv6: parameter p.name is empty
To:     nicolas.dichtel@6wind.com, zhang kai <zhangkaiheb@126.com>,
        davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210603095030.2920-1-zhangkaiheb@126.com>
 <d1085905-215f-fb78-4d68-324bd6e48fdd@6wind.com>
 <dd5b5a62-841c-5a21-7571-78d75e2f2482@gmail.com>
 <3c9bcc89-0ec7-0588-719e-d63b36bef132@6wind.com>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <d4d669fa-f876-7395-16a0-5ab4d45fb61e@gmail.com>
Date:   Thu, 3 Jun 2021 11:09:13 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <3c9bcc89-0ec7-0588-719e-d63b36bef132@6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/3/21 10:29 AM, Nicolas Dichtel wrote:
> Le 03/06/2021 à 17:15, David Ahern a écrit :
>> On 6/3/21 7:33 AM, Nicolas Dichtel wrote:
>>> Le 03/06/2021 à 11:50, zhang kai a écrit :
>>>> so do not check it.
>>>>
>>>> Signed-off-by: zhang kai <zhangkaiheb@126.com>
>>>> ---
>>>>  net/ipv6/addrconf.c | 3 ---
>>>>  1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>>>> index b0ef65eb9..4c6b3fc7e 100644
>>>> --- a/net/ipv6/addrconf.c
>>>> +++ b/net/ipv6/addrconf.c
>>>> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev,
>>>>  	if (err)
>>>>  		return err;
>>>>  
>>>> -	dev = __dev_get_by_name(net, p.name);
>>>> -	if (!dev)
>>>> -		return -ENOBUFS;
>>>>  	return dev_open(dev, NULL);
>>>>  }
>>>>  
>>>>
>>> This bug seems to exist since the beginning of the SIT driver (24 years!):
>>> https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a
>>> Search addrconf_set_dstaddr()
>>>
>>> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>>>
>>
>> A patch was sent yesterday, "sit: set name of device back to struct
>> parms", to set the name field in params.
>>
> Oh yes, it was in my spam folder ...
> 

Really a question for zhang kai about the patches - why both of these.

And from there how did this ever work? addrconf_set_sit_dstaddr should
have been failing for the last 24 years so why fix it vs just ripping it
out.