Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] power: supply: surface-charger: Fix type of integer
 variable
To:     Sebastian Reichel <sre@kernel.org>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>
References: <20210511092421.1928586-1-luzmaximilian@gmail.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <55aafbea-96d4-29f2-8d8b-68f8ac970c6b@gmail.com>
Date:   Thu, 3 Jun 2021 20:37:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210511092421.1928586-1-luzmaximilian@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/11/21 11:24 AM, Maximilian Luz wrote:
> The ac->state field is __le32, not u32. So change the variable we're
> temporarily storing it in to __le32 as well.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>

Friendly ping :)

> ---
>   drivers/power/supply/surface_charger.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> index 81a5b79822c9..a060c36c7766 100644
> --- a/drivers/power/supply/surface_charger.c
> +++ b/drivers/power/supply/surface_charger.c
> @@ -66,7 +66,7 @@ struct spwr_ac_device {
>   
>   static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
>   {
> -	u32 old = ac->state;
> +	__le32 old = ac->state;
>   	int status;
>   
>   	lockdep_assert_held(&ac->lock);
>