Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp498804pxj; Thu, 3 Jun 2021 11:49:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt1aweD56BvdW5n2hSS9wm1jdtxE8V6vY/tqbEphFiRKZ2SSfrO4YYjR9oDm5IODwjKp82 X-Received: by 2002:aa7:cc97:: with SMTP id p23mr847331edt.372.1622746142600; Thu, 03 Jun 2021 11:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622746142; cv=none; d=google.com; s=arc-20160816; b=JvVzDoKiAf8xDT1AlZk/YkSgC2ytAUQZ69UyIeaJMB/VathubpphicA3FZayewT5jG oBIwIgzjUFf/H5/IOyGb/DvdnBM2JHLgIABagjbzqCngvS31kFmLPgof0WhCtTmf4PaQ hO171rfD7GDL2bFRRpfoouWRsOCyIwM9KIjBHZPX6mJLVt9DZRZIbH+6Tb7FadWP7fAD 8RlxHmmbKcNZvqZKzYGauzY1h+b5yzdMDreCTYV/rxmY2H9wIqF36lgoHNAjgJzdxrvy D2joFJTSsG10wKzqc5RBrA+yrzlkr4Gx1AyCSuJG/k+5o5X9mFq18pf259TVN+TgN2lt Q1cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature:dkim-filter; bh=lf8obqIyS2qhtxjR7Mi9MkEGyvvpajHXjSrq3w7AQBw=; b=axpY7rBcEQVvW/+rqt24zcIHzkAKLtpo3zIyCVlI31iFqPZ7HGh/gsrQPq06JUl6De n0BuFCRxvtxu8gjFkhR249QqvL9e6j0k/1iYhJ9SSQBfn5zK+XDz2ho3LyeFAkPgJZB6 1Tism0G5tFx1ZBA+S8RSMQm8kgc5x4cJBnaqrsS5bSTfpqMcbRJLSk+BuZsHrSl/JT6R zDnCNtPhP+kVRAJzRq+m4rKvSp9cHO9pD6nb8BN8RFTUnTsXM9mk0esG/pNNmk1UNxUN /1n1hcAv2hyqrNheXzaTuQlwRdAIEyzhfN87Z53VEKzr2ATobQUWeYWdoKU6Hasd7ZTe Tosg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=IqHYoY2e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si2968703edz.436.2021.06.03.11.48.39; Thu, 03 Jun 2021 11:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=IqHYoY2e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbhFCSrl (ORCPT + 99 others); Thu, 3 Jun 2021 14:47:41 -0400 Received: from linux.microsoft.com ([13.77.154.182]:44720 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhFCSrk (ORCPT ); Thu, 3 Jun 2021 14:47:40 -0400 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by linux.microsoft.com (Postfix) with ESMTPSA id B32AA20B8008; Thu, 3 Jun 2021 11:45:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B32AA20B8008 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1622745955; bh=lf8obqIyS2qhtxjR7Mi9MkEGyvvpajHXjSrq3w7AQBw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IqHYoY2eF51K4B1BRfEAgTvALDlLvh9m8WiqDYT7VaLO9gh/L/YLsH1C8E69nqCKD SXIdkxTZ11PHMWxStuJVNllURVLpim1rPcwpjR0Alv9K8BrGhygXgcccEG6/4CjREM /0dKw3pPaAMwpE5rQO6cgIgoojsVFwCfzI82Smds= Received: by mail-pl1-f173.google.com with SMTP id u9so3288044plr.1; Thu, 03 Jun 2021 11:45:55 -0700 (PDT) X-Gm-Message-State: AOAM5308j+KEEJGQ/VfkAM5GiUWH2oNGP/3MmPyl36sdXpYtg3T6U4x6 io7E1NfugESON7BBot7pgNCAdAqfQ0a4sF8S8I0= X-Received: by 2002:a17:90a:7892:: with SMTP id x18mr643257pjk.39.1622745955243; Thu, 03 Jun 2021 11:45:55 -0700 (PDT) MIME-Version: 1.0 References: <20210521161527.34607-1-mcroce@linux.microsoft.com> <20210521161527.34607-4-mcroce@linux.microsoft.com> In-Reply-To: <20210521161527.34607-4-mcroce@linux.microsoft.com> From: Matteo Croce Date: Thu, 3 Jun 2021 20:45:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling To: netdev@vger.kernel.org, linux-mm@kvack.org Cc: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Yunsheng Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 6:16 PM Matteo Croce wrote: > +bool page_pool_return_skb_page(void *data) > +{ > + struct page_pool *pp; > + struct page *page; > + > + page = virt_to_head_page(data); > + if (unlikely(page->pp_magic != PP_SIGNATURE)) > + return false; > + > + pp = (struct page_pool *)page->pp; > + > + /* Driver set this to memory recycling info. Reset it on recycle. > + * This will *not* work for NIC using a split-page memory model. > + * The page will be returned to the pool here regardless of the > + * 'flipped' fragment being in use or not. > + */ > + page->pp = NULL; > + page_pool_put_full_page(pp, virt_to_head_page(data), false); Here I could just use the cached "page" instead of calling virt_to_head_page() once again. -- per aspera ad upstream