Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp499532pxj; Thu, 3 Jun 2021 11:50:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJximjzHKq5vVws7/+pnrvROMf3CUXU9LAObP9SYPBiUGpVf87hAiVyh2mY9+ucTjOBTrWGf X-Received: by 2002:a17:906:f854:: with SMTP id ks20mr677720ejb.67.1622746216127; Thu, 03 Jun 2021 11:50:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622746216; cv=none; d=google.com; s=arc-20160816; b=aSuZ3wSoe+OLBG+36v+vapk0+rig3shUKxYWuBnEDqu+UukqpaqqSAgq7TZf/twdmh hksnIJiart+viWWsIJkYU4QSfo6eD4KuIqzcTDlDBBqDS87jOwe33WNRyHQnISy7IptD QgwNJH+AQEDEXjWOIHdRDHb7qjwksUgsGRKkGObrHhViEaE5zqrt1dQ8zOu3fL2N/WPr zsZJs172FGoEB6VJTIKWPRug2SnIpbWj0I/ciNlt0fieJVE7/OkBmHW97xxNnBqZZPBy V4aNJfPhrPzGCoLMdv4IBO1cH0n63XNBAIoImzsYA9wUn0ZzHefePHZQ3+Tzse2KgyCg fU4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ZUGi28CzawjzJFRPa1IvCeYStgPTnkk5SqqRbIhNZDM=; b=yr2zJbNTAq//MqT4gxNidzGdwfWNWDJ+sBsNQDk87t9JbRNYyQxd7fZzMqMazpKWbt CM6LnIpCIxxEHzS8GefQEfGA/JTWIeg8etOFC8xgVU7fy8TM1Q18mKbVHG08w9YgZdfE kKDm9y0Z8IAB6FNNXxshQG5DRtYgPH7zxy6xTBAtuY82KHT8CM5kTfEtuPvM3zUvSjh3 MDJy/MHhhFGsKAtXnQqDT9Y54+DAbOQA8u0DfsS/0rZy+irUmvR4p8E+rQ0zCIWbyRWf 5XwTJF2vzwSSAPaGRgrKWuEStYUBMgKyqBhCBm1da9xgavobTenL8dzABZPjwPe7wOvq Sxkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=soH8j4t2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si2799057edu.487.2021.06.03.11.49.51; Thu, 03 Jun 2021 11:50:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=soH8j4t2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbhFCSuS (ORCPT + 99 others); Thu, 3 Jun 2021 14:50:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:55638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbhFCSuS (ORCPT ); Thu, 3 Jun 2021 14:50:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 140F1613F4; Thu, 3 Jun 2021 18:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622746113; bh=ZUGi28CzawjzJFRPa1IvCeYStgPTnkk5SqqRbIhNZDM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=soH8j4t25NOwvyZBPPkJbKQtyXAAn4mzrtMX7uqb2Ajqfc9qqVQZzXVxgrOqs77qY Xl3ftEyqTMUxxFHbsiZM07FAsNHDEbrAWM763p1acyUeLmoTPFia89LgdzyfvXdZdX g1nv5X+rzVxk8jvbe6aH/34P0mjtMvILQPExuvv4LSgrMHxdTAqwtV3HIWvRuJ9cwd z4yOK6cm7k8NyboSpL4W6Whr+46niYdAyMZ0lcy1HscbNbU+x14tCvJE7xdzIfjgIk sn+N8oOYCTktX17MTbukrUS3kiVKP7JYisWZBiEmDkLTuciLPzA1gH3nut4+bc+aVp 0BdMkvyhHybHQ== Received: by mail-ej1-f50.google.com with SMTP id ci15so10709485ejc.10; Thu, 03 Jun 2021 11:48:32 -0700 (PDT) X-Gm-Message-State: AOAM531haRqX2FiZMv0bSRrDhMttmo403AcJaVPfpKo/hZWKBvPpZmc5 FuO0j4JVxq8O3l9mNJfZgyIZzBANTPZnAqwogA== X-Received: by 2002:a17:906:1d0a:: with SMTP id n10mr660877ejh.341.1622746111501; Thu, 03 Jun 2021 11:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20210602215252.695994-1-keescook@chromium.org> <20210602215252.695994-2-keescook@chromium.org> In-Reply-To: From: Rob Herring Date: Thu, 3 Jun 2021 13:48:19 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB To: Kees Cook , Daniel Vetter Cc: Dave Airlie , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , kernel test robot , Sai Prakash Ranjan , Emma Anholt , Rob Clark , Sean Paul , Sharat Masetty , Linus Walleij , Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 3, 2021 at 3:48 AM Daniel Vetter wrote: > > On Wed, Jun 02, 2021 at 02:52:50PM -0700, Kees Cook wrote: > > When cleaning up other drm config dependencies, it is too easy to create > > larger problems. Instead, mark CONFIG_FB as a "depends": > > > > drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! > > > > Suggested-by: Arnd Bergmann > > Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/ > > Signed-off-by: Kees Cook > > I rebased this one for -next and applied all three patches to > drm-misc-next. Patch 3 is not the right fix and I think breaks some platforms. Rob