Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Jun 2021 17:10:10 -0400
From:   David Rivshin <drivshin@awxrd.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: is31fl32xx: Fix missing error code in
 is31fl32xx_parse_dt()
Message-ID: <20210603171010.37fbf545.drivshin@awxrd.com>
In-Reply-To: <1622545743-21240-1-git-send-email-jiapeng.chong@linux.alibaba.com>
References: <1622545743-21240-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Organization: Allworx
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue,  1 Jun 2021 19:09:03 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
> 
> Eliminate the follow smatch warning:
> 
> drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
> error code 'ret'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Good catch!

Acked-by: David Rivshin <drivshin@allworx.com>

You might also want to add a:

Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")


> ---
>  drivers/leds/leds-is31fl32xx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c
> index 2180255..899ed94 100644
> --- a/drivers/leds/leds-is31fl32xx.c
> +++ b/drivers/leds/leds-is31fl32xx.c
> @@ -385,6 +385,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
>  			dev_err(dev,
>  				"Node %pOF 'reg' conflicts with another LED\n",
>  				child);
> +			ret = -EINVAL;
>  			goto err;
>  		}
>