Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp632838pxj; Thu, 3 Jun 2021 15:40:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznn6RJ/rpdb91GrXxF+EdVcm8RHAdpR72zPKqqfafcVmmkQwUzuLX0W0dHcOeUcwgNR0gX X-Received: by 2002:a17:906:6ad0:: with SMTP id q16mr1415217ejs.286.1622760017507; Thu, 03 Jun 2021 15:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622760017; cv=none; d=google.com; s=arc-20160816; b=HRPbKpXNZEawKDG0mZ8aswQW4AF6p0if849kV2YSwFx7mybZw3h3vUPXX3HjAq71nl DrS+H8Ow3D9TpdlY5tTizMaVEKQh+H3mBpJoV0hAP8LAHDsB8UqxV7MEVpuqRl28xIW+ +S3sBLAyuaG9pWIcoRM75fFbNzn6ZW9AwPFZC1moe/waeyFKz8ytzn5VCCCcwodwVIf4 eCO6VMKKqGKy1NuNFMzCpgapAPkozE+egFwtpcPR7GyfRj+GrB+pyxdFwaCyLD8YdXvo 6yBoSNqRlbDG3pPB9gXKHd0IFFs5PKE8P9fUAFlAd47hoP49MGJ1+HC3MyaEcnoKl9mf 0ktQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HwtNxFZWs3kgiS1MAdB6GTo/9UThlmF9FY/Reo2Q1W0=; b=DsMqylLVZ0doTuVKdwnRESbUrnLaaqoKGFKsQQvLdHMdK1lLbbpIxj9rkjgFLj3p1P RSR0JchEQw/MrNY1hL+gsfQouvYWPOCSOG+s2hBa1SFmk2n400aFhMBj+1G9dAwYE1IF aoGt4vXDO2J8rRX8tHWu3I8wkYQAz2E/bIux2HGkqh7wiR1cZ5oSLwm7HVB+ZldZUHXH bgiT9QgLs4aP+xvGcH0oA7RTjbVBAD6pSOD6mdYvLN40+RakG2ajyWm9w4uNwWQTAGMl 2O90F0G3JZHJYD0PPPd29NjiGFfXHIKJONACvm8An1lLuJE1g1vhdyduZqKaFDik7fEi jOXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z6lmdhTm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg13si3041169ejc.566.2021.06.03.15.39.47; Thu, 03 Jun 2021 15:40:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z6lmdhTm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbhFCWjU (ORCPT + 99 others); Thu, 3 Jun 2021 18:39:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:43332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhFCWjT (ORCPT ); Thu, 3 Jun 2021 18:39:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 383EC613FF; Thu, 3 Jun 2021 22:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622759854; bh=Q7AfV/pFWoppLJ7RBW4CDh3xUENOSj+9wxs4Ekg70Qg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z6lmdhTmAOwe1A+Cq5SsLmxCrBGgXbdHlYkMm3YzL3+698KCYhoBnKYjGxZilzbb2 zMMuOhF+EYQUu+TnpDTtdHqhTgK/oWXrbkmA/0dyV2Rl9+62bk4kd2+J0VmsUJE+Vy 0UANhxnqSm401KUJYlH033zb9/7xF1YwuZvA5GVHYkdR88s5N2OW0Top3Y/Z+Hcw2i +HuSkUjbRxDjL6bZKvq2hPR5d8DpLO2/x2DpucQMjzfzPAVa/5JXF+hjPvM+ADXGju NmB/zgvIs8NYy0lHBfQ07qsCKq0ijx6hwpSWat+MkQxbqjinHQUan0gLQx1rDQ2/DO oLLorWUQ/52cQ== Date: Thu, 3 Jun 2021 15:37:33 -0700 From: "Darrick J. Wong" To: "ruansy.fnst@fujitsu.com" Cc: "dan.j.williams@intel.com" , "linux-fsdevel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "linux-xfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "darrick.wong@oracle.com" , "willy@infradead.org" , "jack@suse.cz" , "viro@zeniv.linux.org.uk" , "linux-btrfs@vger.kernel.org" , "david@fromorbit.com" , "hch@lst.de" , "rgoldwyn@suse.de" Subject: Re: [PATCH v3 0/3] fsdax: Factor helper functions to simplify the code Message-ID: <20210603223733.GF26380@locust> References: <20210422134501.1596266-1-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 10:23:25AM +0000, ruansy.fnst@fujitsu.com wrote: > > > > Hi, Dan > > > > Do you have any comments on this? > > Ping This patchset has acquired multiple RVB tags but (AFAIK) Dan still hasn't responded. To get this moving again, it might be time to send this direct to Al with a note that the maintainer hasn't been responsive. --D > > > > > > -- > > Thanks, > > Ruan Shiyang. > > > > > -----Original Message----- > > > From: Shiyang Ruan > > > Sent: Thursday, April 22, 2021 9:45 PM > > > Subject: [PATCH v3 0/3] fsdax: Factor helper functions to simplify the > > > code > > > > > > From: Shiyang Ruan > > > > > > The page fault part of fsdax code is little complex. In order to add > > > CoW feature and make it easy to understand, I was suggested to factor > > > some helper functions to simplify the current dax code. > > > > > > This is separated from the previous patchset called "V3 fsdax,xfs: Add > > > reflink&dedupe support for fsdax", and the previous comments are here[1]. > > > > > > [1]: > > > https://patchwork.kernel.org/project/linux-nvdimm/patch/20210319015237 > > > .99 > > > 3880-3-ruansy.fnst@fujitsu.com/ > > > > > > Changes from V2: > > > - fix the type of 'major' in patch 2 > > > - Rebased on v5.12-rc8 > > > > > > Changes from V1: > > > - fix Ritesh's email address > > > - simplify return logic in dax_fault_cow_page() > > > > > > (Rebased on v5.12-rc8) > > > == > > > > > > Shiyang Ruan (3): > > > fsdax: Factor helpers to simplify dax fault code > > > fsdax: Factor helper: dax_fault_actor() > > > fsdax: Output address in dax_iomap_pfn() and rename it > > > > > > fs/dax.c | 443 > > > +++++++++++++++++++++++++++++-------------------------- > > > 1 file changed, 234 insertions(+), 209 deletions(-) > > > > > > -- > > > 2.31.1 > > > > >