Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp703068pxj; Thu, 3 Jun 2021 17:53:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwks4MZQww5LZJA5rv9syQbY2PlBkLsxa+c0I3RnmMoedRNEjBEEeGFD+FaV0hSumeNPR4V X-Received: by 2002:a17:906:a12:: with SMTP id w18mr1788205ejf.92.1622767991431; Thu, 03 Jun 2021 17:53:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622767991; cv=none; d=google.com; s=arc-20160816; b=mlD3+JLmlhJ7JT5jts2vlKlFwZNQF+FFDDVGivGUEjlb93uFbw3Yi16xgw9V3gUZki Uf1oKXvm85FT0o6ZytujFPy6q8K/cBOabmH5LLpL6aOgz8iYM3zy4hFdMIkwsLaE063B ndYC9vrsfPNG2Zyi3zLSDvXJpKheWo82oui+a4h2NE0ZCGT6r/4CwqlEvQl7z6qdWIYe XSYoBwWhzEnYFMEDTwe0zDD5vHbANPqBgp7JPbZ4Alr0frdySOG6xZkp5cT+Z7iYuX7f vgdwtsHSc4IYH2EJ9sitmCCtYjYl/D3/rJ/M3x3GdV21QdvNB9mUIyzLDiefB4EnKPTf XMNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=Iwimm5kt1cPOS3WktKznx8Tm3YSJawu3yuys6bu5NIU=; b=N2PNSvDmIK4Lxfln397kCCvaImYp0xAhhJoJvefzAoJKQ24UdT4qvjuu8Tx9nCMdss DGg4B1yLghRb/DFlc03M0dRwWT12lWrpQA5rW02RdroNl/L7TDalQzTa5ukZUCi3l3je vjchlfmGn3zZZc9T2zFVHDPO20PlCigEG3CEtaZb2TCQFVYSWs2kW69kR+r9fLh3R6Z7 T/ZJd71ev0DqvAg3j14ZUS3oPtiBfMIugxz3BzpiYI/QxXFw4L+qWP+vDpSUdN31dEb0 rLZCGi56TAQ9v5UiZQl9sO6ARJYpH18uN26KVCU5TF3zW1in5ZQccZu9nlt3G2xllTP2 LPAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Gs5lp5tf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si3591717edz.248.2021.06.03.17.52.48; Thu, 03 Jun 2021 17:53:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Gs5lp5tf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbhFDAwx (ORCPT + 99 others); Thu, 3 Jun 2021 20:52:53 -0400 Received: from mail-lf1-f43.google.com ([209.85.167.43]:40683 "EHLO mail-lf1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFDAww (ORCPT ); Thu, 3 Jun 2021 20:52:52 -0400 Received: by mail-lf1-f43.google.com with SMTP id w33so11522261lfu.7 for ; Thu, 03 Jun 2021 17:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Iwimm5kt1cPOS3WktKznx8Tm3YSJawu3yuys6bu5NIU=; b=Gs5lp5tfCZGV7HaOOLREF2vdGYMqTNw3RNRfVR02KWcpUPpLyAkDZxU7KzZFEpILnW TS0t5Tw3jHP2Ob59G1pCQ6LYWQnMUKiuyHK3lTTIefXm7iqwG9uq0eGTtxJAGrSis2Ek NgYpfpSBSpngnF6vNhFkr+azyg64Nbj9wU4YUX7k4Dz0Mu3a5c83ByA1JJIQ++3PzJA6 vDwZiKtp6AAOuGW+JBWR48V9np7igTsW2Fn7/DOOm8HTKOkQD5ZzGiEpusGlmlULy59v kW8Wrs3I4DQqP6mQqK141gPFmWUyx5cOt7ntAA6X/nilYQsGyV/6fTzlwq5TQsgRvMrV 133A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Iwimm5kt1cPOS3WktKznx8Tm3YSJawu3yuys6bu5NIU=; b=MQCDh3VUOCFwmza8SaBxkcqZWvvSCh8y46uHVMDmmqXkI4f0lwxGgAkhh7WjzCDpPK vtQGE5bFyJIGQeSBuIsixxrjvgwQipL5T9poyRTZrlUPLQu5Fcxpd/3zJkEBtPnyDOCY gvLHgTZLKd2oS9gzbL1CePgiOZ2YSq1pO3TBekCFU729FoxSdOGUFky9xqgNqnkxs72q +rpXDK4WWuKL096utZUm37PmB0aRIix7r29HQ5O9Bzm0qOMO3TexrDO4QJPvHEJid+dp kJp0BcFCnbW2P7r7zGLENFmzTDvb3CHfPYQ6q4MCEH8j01NH9iLI44J+LUhCbFN4e2Nl MJIA== X-Gm-Message-State: AOAM532pMY8ghhs1y91AU6ko5g5JW7hfkzFfpb9PDD6ehVvjPF8DfNgw 43zFZRBp0hTjVOcOqUyd1meRcg== X-Received: by 2002:a05:6512:32ab:: with SMTP id q11mr961056lfe.21.1622767793930; Thu, 03 Jun 2021 17:49:53 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id p26sm448515ljn.33.2021.06.03.17.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 17:49:53 -0700 (PDT) Subject: Re: [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses To: Lee Jones Cc: linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20210602143300.2330146-1-lee.jones@linaro.org> <20210602143300.2330146-13-lee.jones@linaro.org> From: Dmitry Baryshkov Message-ID: Date: Fri, 4 Jun 2021 03:49:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210602143300.2330146-13-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2021 17:32, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/msm_gem.c:364: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > drivers/gpu/drm/msm/msm_gem.c:763: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian König" > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index 56df86e5f7400..15434deb19334 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -372,7 +372,7 @@ static void del_vma(struct msm_gem_vma *vma) > kfree(vma); > } > > -/** > +/* > * If close is true, this also closes the VMA (releasing the allocated > * iova range) in addition to removing the iommu mapping. In the eviction > * case (!close), we keep the iova allocated, but only remove the iommu > @@ -773,7 +773,7 @@ void msm_gem_purge(struct drm_gem_object *obj) > 0, (loff_t)-1); > } > > -/** > +/* > * Unpin the backing pages and make them available to be swapped out. > */ > void msm_gem_evict(struct drm_gem_object *obj) > -- With best wishes Dmitry