Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bc45bf20461fda09e7b224465285f1385cdab09b.camel@ozlabs.org>
Subject: Re: [PATCH] fsi: core: Fix return of error values on failures
From:   Jeremy Kerr <jk@ozlabs.org>
To:     Colin King <colin.king@canonical.com>,
        Joel Stanley <joel@jms.id.au>,
        Alistar Popple <alistair@popple.id.au>,
        Eddie James <eajames@linux.ibm.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        linux-fsi@lists.ozlabs.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 04 Jun 2021 09:44:33 +0800
In-Reply-To: <20210603122812.83587-1-colin.king@canonical.com>
References: <20210603122812.83587-1-colin.king@canonical.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Colin,
> Currently the cfam_read and cfam_write functions return the provided
> number of bytes given in the count parameter and not the error return
> code in variable rc, hence all failures of read/writes are being
> silently ignored. Fix this by returning the error code in rc.

Looks good to me, thanks for the fix.

Reviewed-by: Jeremy Kerr <jk@ozlabs.org>

Cheers,


Jeremy