Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v35 3/4] scsi: ufs: Prepare HPB read for cached sub-region
To:     daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
References: <12392bef-e018-8260-5279-16b7b43f5a8f@acm.org>
 <20210524084345epcms2p63dde85f3fdc127c29d25ada7d7f539cb@epcms2p6>
 <20210524084546epcms2p2c91dc1df482fd593307892825532c6dd@epcms2p2>
 <CGME20210524084345epcms2p63dde85f3fdc127c29d25ada7d7f539cb@epcms2p3>
 <20210604011124epcms2p39a466db169ebbfd2c889e25fba9aa0b4@epcms2p3>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <4bf317c8-4c74-2207-95e2-34c59b14c454@acm.org>
Date:   Thu, 3 Jun 2021 19:54:14 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210604011124epcms2p39a466db169ebbfd2c889e25fba9aa0b4@epcms2p3>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/3/21 6:11 PM, Daejun Park wrote:

>>> +/*
>>> + * This function will set up HPB read command using host-side L2P map data.
>>> + * In HPB v1.0, maximum size of HPB read command is 4KB.
>>> + */
>>> +void ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
>>> +{
>> [ ... ]
>>> +
>>> +        ufshpb_set_hpb_read_to_upiu(hpb, lrbp, lpn, ppn, transfer_len);
>>
>> 'transfer_len' has type int and is truncated to type 'u8' when passed as
>> an argument to ufshpb_set_hpb_read_to_upiu(). Please handle transfer_len
>> values >= 256 properly.
> 
> Before entering the function, ufshpb_is_supported_chunk() checks whether
> transfer_len <= hpb->pre_req_max_tr_len which is set to
> HPB_MULTI_CHUNK_HIGH (128) on initalization.

How about adding a WARN_ON_ONCE() in ufshpb_prep() that verifies that
transfer_len is <= HPB_MULTI_CHUNK_HIGH?

Thanks,

Bart.