Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp873118pxj; Thu, 3 Jun 2021 23:44:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHYmPn6dU2JwsY/ffnzLJopmFjXrCEoqV8YLattBDlRc40euTk8eg+QNXBxEce8XPUL9AF X-Received: by 2002:aa7:dc12:: with SMTP id b18mr3167706edu.52.1622789072659; Thu, 03 Jun 2021 23:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622789072; cv=none; d=google.com; s=arc-20160816; b=yMNsCJISIWHn1gcWD56e1rLK+6aG6iuVhsJiMuXWwCi6Y8q7BW6v5GMfRqcm36XAPB SqxNgZsOGNeDSrVFhZUmyfxWNBKZQ3WAclXL0sjBA661xk/SSeMKl0A4Yu/8pKmY7obN 6sB7CXpKqRHSqRE3tfx66SoNPzsfc8Cw74miTSGDDzPvMVpaI6Fc8k3vOFf5bikHuowT i68wr3bZhR/+Pjnh7uLIDQgcIADVOhlNY0f26y4GO7BK9iDNyGhtFAdHrF87DFT3oYzi 9O2FJnsCMK1jM1lL8aD0g5h1KQNQv0S3bD5z/tKB1QvEa0RGzlW5V6hLBIusMABuO4I6 6yNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=S17fN/ibPAMCQWFy+84ZG8Iso2Ij4GxnGWq2PMVnDm8=; b=AhDA6nGcxjaPf5jtu596f1vcDc54Ul8xJqC32Mu1i6y7ilQOzt4YcN2G+KE8jXd9nV +bWTEcte5wj9GsceO5MXl8QuO8+TYs7XmPfDR6nZui3+/PbYGqsMtPuJA2pfgpdqGXda 7umL+ttW4+fqOF0R2L8zsm2cFeW5LHFtVHFExfAk1/loZfhdfdgyQ7erqOksBmVxCQ/+ IoHFLMpqbFExngCLVvEZ55kFt2p57mj2Cnf2jhOcNwj4TlEDZSx9TezsD1MfqlKZxn/o eFwtduHa90vtF7S7WRgOWEug6jrh+lf3P5CIu3uV5Ny+0I6hnUWYnu2l1hlPDLJLN6qB HOVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=IxbiGkMe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd3si3979935edb.307.2021.06.03.23.44.08; Thu, 03 Jun 2021 23:44:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=IxbiGkMe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbhFDGno (ORCPT + 99 others); Fri, 4 Jun 2021 02:43:44 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:60726 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbhFDGno (ORCPT ); Fri, 4 Jun 2021 02:43:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1622788918; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=S17fN/ibPAMCQWFy+84ZG8Iso2Ij4GxnGWq2PMVnDm8=; b=IxbiGkMeUH9i/nhHPoFF6mttK9laKMIndc2LdM7tZXPeBQ9lxRs2oOz+diF8ceR5qWR8Fgut dwGdhlXpPVSD9lCqCE+bTceLqMBu1iygt6Aebrhyh5tUbclboPjDVGIlHPIW51uxOOSmzAHt Lc6kaHHwembTsPO8HZY2+2jkjsc= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60b9cb35e27c0cc77f48d6fe (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 04 Jun 2021 06:41:57 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E632BC43217; Fri, 4 Jun 2021 06:41:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id B780CC433F1; Fri, 4 Jun 2021 06:41:54 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 04 Jun 2021 14:41:54 +0800 From: Can Guo To: Changheun Lee Cc: Johannes.Thumshirn@wdc.com, alex_y_xu@yahoo.ca, asml.silence@gmail.com, axboe@kernel.dk, bgoncalv@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, bvanassche@acm.org, damien.lemoal@wdc.com, gregkh@linuxfoundation.org, hch@infradead.org, jaegeuk@kernel.org, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ming.lei@redhat.com, osandov@fb.com, patchwork-bot@kernel.org, tj@kernel.org, tom.leiming@gmail.com, yi.zhang@redhat.com, jisoo2146.oh@samsung.com, junho89.kim@samsung.com, mj0123.lee@samsung.com, seunghwan.hyun@samsung.com, sookwan7.kim@samsung.com, woosung2.lee@samsung.com, yt0928.kim@samsung.com Subject: Re: [PATCH v12 0/3] bio: control bio max size In-Reply-To: <20210604050324.28670-1-nanich.lee@samsung.com> References: <20210604050324.28670-1-nanich.lee@samsung.com> Message-ID: <0e7fbebf0877fd5d87c156c6020eeb09@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-04 13:03, Changheun Lee wrote: > bio size can grow up to 4GB after muli-page bvec has been enabled. > But sometimes large size of bio would lead to inefficient behaviors. > Control of bio max size will be helpful to improve inefficiency. > > blk_queue_max_bio_bytes() is added to enable be set the max_bio_bytes > in > each driver layer. And max_bio_bytes sysfs is added to show current > max_bio_bytes for each request queue. > bio size can be controlled via max_bio_bytes. > This is interesting, and we also noticed it right after multi-page bvec is enabled since last year. Internally, we had a hack to disable it. But it is good to have a tunable to control it. Thanks for the change. Reviewed-by: Can Guo > Changheun Lee (3): > bio: control bio max size > blk-sysfs: add max_bio_bytes > ufs: set max_bio_bytes with queue max sectors > > Documentation/ABI/testing/sysfs-block | 10 ++++++++++ > Documentation/block/queue-sysfs.rst | 7 +++++++ > block/bio.c | 17 ++++++++++++++--- > block/blk-settings.c | 19 +++++++++++++++++++ > block/blk-sysfs.c | 7 +++++++ > drivers/scsi/ufs/ufshcd.c | 5 +++++ > include/linux/bio.h | 4 +++- > include/linux/blkdev.h | 3 +++ > 8 files changed, 68 insertions(+), 4 deletions(-)