Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Santosh Sivaraj <santosh@fossix.org>
To:     Wu Bo <wubo40@huawei.com>, dan.j.williams@intel.com,
        vishal.l.verma@intel.com, dave.jiang@intel.com,
        ira.weiny@intel.com, bp@suse.de, rafael.j.wysocki@intel.com,
        mpe@ellerman.id.au, nvdimm@lists.linux.dev,
        linux-kernel@vger.kernel.org
Cc:     linfeilong@huawei.com, wubo40@huawei.com
Subject: Re: [PATCH] tools/testing/nvdimm: use vzalloc() instead of
 vmalloc()/memset(0)
In-Reply-To: <1622425715-146012-1-git-send-email-wubo40@huawei.com>
References: <1622425715-146012-1-git-send-email-wubo40@huawei.com>
Date:   Fri, 04 Jun 2021 12:18:32 +0530
Message-ID: <87tumem8fz.fsf@desktop.fossix.local.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Wu Bo <wubo40@huawei.com> writes:

> Use vzalloc() instead of vmalloc() and memset(0) to simpify
> the code.
>
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
>  tools/testing/nvdimm/test/nfit.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

LGTM,

Reviewed-by: Santosh S <santosh@fossix.org>

>
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index 54f367cbadae..258bba22780b 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -1625,7 +1625,6 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma,
>  	if (rc)
>  		goto err;
>  	INIT_LIST_HEAD(&nfit_res->list);
> -	memset(buf, 0, size);
>  	nfit_res->dev = dev;
>  	nfit_res->buf = buf;
>  	nfit_res->res.start = *dma;
> @@ -1652,7 +1651,7 @@ static void *test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma)
>  	struct genpool_data_align data = {
>  		.align = SZ_128M,
>  	};
> -	void *buf = vmalloc(size);
> +	void *buf = vzalloc(size);
>  
>  	if (size >= DIMM_SIZE)
>  		*dma = gen_pool_alloc_algo(nfit_pool, size,
> -- 
> 2.30.0