Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: MEZbheGEAhI0GV4GNNsYQb1LA6vyy1JPkGUi1FCWum6S+fISxGrH1nzKdSbe/5y3EEStGFnM0G
 8rGeyMJKr5gg==
IronPort-SDR: V+P0ql+gHJzXPiCjBWgWKilAULWEM/bBQCh3FYLRvSux6W0QduS12IbM4VFpRB7kBoCtEiGokq
 qtd33cL2dtnA==
From:   "Voon, Weifeng" <weifeng.voon@intel.com>
To:     Vladimir Oltean <olteanv@gmail.com>,
        "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>
CC:     "Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
        "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "Tan, Tee Min" <tee.min.tan@intel.com>,
        "vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RESEND PATCH net-next v4 1/3] net: stmmac: split xPCS setup from
 mdio register
Thread-Topic: [RESEND PATCH net-next v4 1/3] net: stmmac: split xPCS setup
 from mdio register
Thread-Index: AQHXWG9VZDAInycEtECS03SHnnEzzKsCRbMAgAAH7wCAACh0gIAAybNw
Date:   Fri, 4 Jun 2021 06:53:42 +0000
Message-ID: <CH0PR11MB53805074303D0F06738FCD40883B9@CH0PR11MB5380.namprd11.prod.outlook.com>
References: <20210603115032.2470-1-michael.wei.hong.sit@intel.com>
 <20210603115032.2470-2-michael.wei.hong.sit@intel.com>
 <20210603132056.zklgtbsslbkgqtsn@skbuf>
 <SA2PR11MB50513D751429D3D456A5A9409D3C9@SA2PR11MB5051.namprd11.prod.outlook.com>
 <20210603161407.457olvjmia3zoj6w@skbuf>
In-Reply-To: <20210603161407.457olvjmia3zoj6w@skbuf>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd682fb-0f0d-4d4d-caaf-08d927257dae
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2021 06:53:42.4122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: d8ZhraB3QlWBhu3C7Ue0S3F1mgYcpFVAL5UEaOnt68H5XLw0U4dyxKOhXP8eB3MIdlHZIFZLVSRFYvLyd76pFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5251
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -7002,6 +7006,9 @@ int stmmac_dvr_probe(struct device *device,
>  		}
>  	}
>=20
> +	if (priv->plat->speed_mode_2500)
> +		pri*v->plat->speed_mode_2500(ndev, priv->plat->bsp_priv);
> +
>  	if (priv->plat->mdio_bus_data->has_xpcs) {
>  		ret =3D stmmac_xpcs_setup(priv->mii);
>  		if (ret)
>=20
> With the current placement, there seems to be indeed no way for the
> platform-level code to set plat->phy_interface after the MDIO bus has
> probed but before the XPCS has probed.
>=20
> I wonder whether it might be possible to probe the XPCS completely
> outside of stmmac_dvr_probe(); once that function ends you should have
> all knowledge necessary to set plat->phy_interface all within the
> Intel platform code. An additional benefit if you do this is that you
> no longer need the has_xpcs variable - Intel is the only one setting
> it right now, as far as I can see. What do you think?

Hi Vladimir, I still think that stmmac_dvr_probe() the suitable place to
probe the XPCS together with MDIO and PHY setup. In addition, XPCS also
need to be probed before stmmac_open()as there is an checking of XPCS AN
mode at the very beginning of the function.=20

The has_xpcs variable is introduced in the very first commits in the XPCS d=
esign.
Although currently Intel is the only one using it, it is beneficial for any
future system that pair stmmac with xpcs. =20

Weifeng