Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp887471pxj; Fri, 4 Jun 2021 00:11:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg6iiGmvYQkbnfHJtazkoigrYVvnkFQBgxQd+Cqr1wobHXh/V13UP6mhQN71/JDY7wfsVj X-Received: by 2002:a17:907:961e:: with SMTP id gb30mr2996727ejc.58.1622790708412; Fri, 04 Jun 2021 00:11:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622790708; cv=none; d=google.com; s=arc-20160816; b=i3a9hAe8VPayC7sPYsF4aIikJsM3BBM7bYaJneoKxqCChWET/k5ETKNkW8oW27oj+L MkILTbTJMYqGRxuppEY7B6NSH0n1TZGYHXQGThEt8UYMyohwQUjsUrol3hhb8+B+LfWg y23yAOp+w6h1btmmjxu15xMMK6TNzoL7v46oJe6ZwHT9RCiJ2vmu0qy4yf3mmdULqLv5 I3MuGFUyJ1NSc2sSRQT5sqCL6B0KX1Th4zJgtaReDruVE/fWUU4T+kLip3tbGp+Rr0L9 I/Bvb2aPmmSMixAxEApBkeNoOR/F+MdJdHkHeXsBK3vnEBR4OYYCJq5D7yDFNzMPngzj iy6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6loRrjrbd0iaVe9iv7Hdnp7YFC8HX63Ds/RqTQ8EkUI=; b=JaAnCQYWjiHm7d4Itp4z6u0Ul09g4O+Gw5lZz1SIk95+LbTjqaricOuOoWhOwJokOP vMunXZGkDFRvsiCjS/9hvOUWen6rBvCXhYUQWHx4s26lV9dhJDGx+16SJyNsrtsDrcd6 SEllDYvzoMFtoTuL8Za6LocfZ/ey2JQjZ1T4caQSt4UtE10lrVT+JrZ92Pn6bvqs355T nPATJYvhijqnnLV6Y9xoWdkjSx5U4CH+3E6W0BkLi5LTADsku9GknFxC7yLqv3+prXXi fn2gvHQ/MYJDz3BqkBs0zPV+i3uGnXv5RqxU91Hr/KW6KrwPr4MMR75N0MytybGuAMB1 AD7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si4158063ejb.193.2021.06.04.00.11.22; Fri, 04 Jun 2021 00:11:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbhFDHLq (ORCPT + 99 others); Fri, 4 Jun 2021 03:11:46 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4468 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhFDHLq (ORCPT ); Fri, 4 Jun 2021 03:11:46 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FxDNJ2lh2zZcPQ; Fri, 4 Jun 2021 15:07:12 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 15:09:58 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 15:09:58 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH -next v2] scsi: mpi3mr: Make some symbols static Date: Fri, 4 Jun 2021 15:14:07 +0800 Message-ID: <20210604071407.1360742-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following warnings: drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static? drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static? drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- v2: move extern int prot_mask to mpi3mr.h --- drivers/scsi/mpi3mr/mpi3mr.h | 1 + drivers/scsi/mpi3mr/mpi3mr_fw.c | 1 - drivers/scsi/mpi3mr/mpi3mr_os.c | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr.h b/drivers/scsi/mpi3mr/mpi3mr.h index 5d5529167350..6f5dc9e78553 100644 --- a/drivers/scsi/mpi3mr/mpi3mr.h +++ b/drivers/scsi/mpi3mr/mpi3mr.h @@ -50,6 +50,7 @@ /* Global list and lock for storing multiple adapters managed by the driver */ extern spinlock_t mrioc_list_lock; extern struct list_head mrioc_list; +extern int prot_mask; #define MPI3MR_DRIVER_VERSION "00.255.45.01" #define MPI3MR_DRIVER_RELDATE "12-December-2020" diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c index 8aea1c2ae712..4a007cf54ad7 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c @@ -9,7 +9,6 @@ #include "mpi3mr.h" #include -extern int prot_mask; #if defined(writeq) && defined(CONFIG_64BIT) static inline void mpi3mr_writeq(__u64 b, volatile void __iomem *addr) diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c index a54aa009ec5a..eec0b269a4db 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -25,10 +25,10 @@ int prot_mask = -1; module_param(prot_mask, int, 0); MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07"); -int prot_guard_mask = 3; +static int prot_guard_mask = 3; module_param(prot_guard_mask, int, 0); MODULE_PARM_DESC(prot_guard_mask, " Host protection guard mask, def=3"); -int logging_level; +static int logging_level; module_param(logging_level, int, 0); MODULE_PARM_DESC(logging_level, " bits for enabling additional logging info (default=0)"); -- 2.25.1